Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read or write to event attributes with dynamically alloc'd keys #3174

Closed
wants to merge 111 commits into from

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented May 6, 2024

Describe your changes

Closes #3178

Required by #3103

Add the ability to read or write to event attributes with dynamically allocated attribute keys.

Indicate on which release or other PRs this topic is based on

#3141

Diff for review: https://github.com/anoma/namada/compare/tiago/balance-change-events..tiago/extra-event-attrs

Working CI: #3178

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 requested review from tzemanovic and grarco May 6, 2024 12:08
@sug0 sug0 changed the title Tiago/extra event attrs Read or write to event attributes with dynamically alloc'd keys May 6, 2024
@sug0 sug0 marked this pull request as ready for review May 6, 2024 12:13
Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 62.28518% with 812 lines in your changes are missing coverage. Please review.

Project coverage is 59.62%. Comparing base (ea843f7) to head (1d05270).
Report is 21 commits behind head on main.

Files Patch % Lines
crates/ibc/src/event.rs 46.94% 113 Missing ⚠️
crates/events/src/extend.rs 68.00% 104 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 88 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 14.13% 79 Missing ⚠️
crates/governance/src/event.rs 52.21% 54 Missing ⚠️
crates/events/src/lib.rs 71.59% 50 Missing ⚠️
crates/events/src/extend/dynamic.rs 61.22% 38 Missing ⚠️
crates/sdk/src/rpc.rs 0.00% 32 Missing ⚠️
crates/state/src/wl_state.rs 0.00% 30 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 29.41% 24 Missing ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
+ Coverage   59.41%   59.62%   +0.21%     
==========================================
  Files         298      304       +6     
  Lines       92326    93379    +1053     
==========================================
+ Hits        54853    55681     +828     
- Misses      37473    37698     +225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sug0 added a commit that referenced this pull request May 6, 2024
@sug0 sug0 mentioned this pull request May 6, 2024
@sug0 sug0 marked this pull request as draft May 6, 2024 16:08
@sug0 sug0 closed this May 7, 2024
@sug0 sug0 deleted the tiago/extra-event-attrs branch May 7, 2024 12:33
@sug0
Copy link
Contributor Author

sug0 commented May 7, 2024

closed in favor of modifying the wasm host fn tx_emit_event to include an extra attribute in the emitted event containing a hash of the commitments of the tx emitting the event

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants