Update sample with more documentation and remove Toasts #1116
Conversation
kul3r4
commented
Jun 5, 2024
kul3r4
commented
- remove Toasts and create 2 separate screens for showing nodes
- Update ReadMe with more details and point to Horologist for specific use cases
kul3r4
force-pushed
the
datalayer-version2
branch
3 times, most recently
from
b2c85ce to
f44e771
Compare
DataLayer/Application/src/main/java/com/example/android/wearable/datalayer/MainActivity.kt
Outdated
Show resolved
Hide resolved
DataLayer/Wearable/src/main/java/com/example/android/wearable/datalayer/ConnectedNodesScreen.kt
Outdated
Show resolved
Hide resolved
| * This form is easier to work with when trying to operate upon all [Node]s. | ||
| */ | ||
| private suspend fun getCapabilitiesForReachableNodes(): Map<Node, Set<String>> = | ||
| capabilityClient.getAllCapabilities(CapabilityClient.FILTER_REACHABLE) |
There was a problem hiding this comment.
This call can fail, so we should probably catch the ApiExceptions and log?
There was a problem hiding this comment.
Under which circumstances can fail?
There was a problem hiding this comment.
It's not likely, more about correct code.
https://developers.google.com/android/reference/com/google/android/gms/wearable/WearableStatusCodes
I think any call can technically fail with TIMEOUT, REMOTE_EXCEPTION, INTERNAL_ERROR.
#tioli
There was a problem hiding this comment.
We should consider these a remote call to another process on the device.
DataLayer/Wearable/src/main/java/com/example/android/wearable/datalayer/NodesScreen.kt
Outdated
Show resolved
Hide resolved
DataLayer/Wearable/src/main/java/com/example/android/wearable/datalayer/MainApp.kt
Outdated
Show resolved
Hide resolved
| fun MainScreen( | ||
| onShowNodesList: () -> Unit, | ||
| onShowCameraNodesList: () -> Unit, | ||
| image: Bitmap?, |
There was a problem hiding this comment.
Bitmap might not be a good type on a Composable function. We should probably introduce some data class and mark it Stable?
| setContent { | ||
| MainApp( | ||
| events = clientDataViewModel.events, | ||
| image = clientDataViewModel.image, | ||
| onQueryOtherDevicesClicked = ::onQueryOtherDevicesClicked, | ||
| onQueryMobileCameraClicked = ::onQueryMobileCameraClicked | ||
| nodesViewModel = nodesViewModel |
There was a problem hiding this comment.
This API feels a bit weird. you have state from clientDataViewModel and nodesViewModel directly.
Should we remove clientDataViewModel here and move that logic into some MainAppViewModel?
There was a problem hiding this comment.
Good point, at the moment the clientDataViewModel is extending the various listeners (message, capability etc.) and overrides the onchanged but we also have a DataLayerListenerService that implements the WearableListenerService and there again the onchanged methods are overriden. Perhaps we should try to keep only one place where those are overriden?
There was a problem hiding this comment.
Moved the nodesViewModel creation, e.g.
fun CameraNodesScreen(
viewModel: NodesViewModel = viewModel(factory = NodesViewModel.Factory)
There was a problem hiding this comment.
For the other part of the comment related to creation of the ViewModel, tracking it in #1119
kul3r4
force-pushed
the
datalayer-version2
branch
3 times, most recently
from
6b1f5c7 to
a879492
Compare
kul3r4
force-pushed
the
datalayer-version2
branch
from
a879492 to
d0321b2
Compare
|
Related to #1039 |
