Uses Horologist DataHelpers in DataLayer sample #1111
Conversation
| @@ -29,7 +29,7 @@ android { | |||
| applicationId "com.example.android.wearable.datalayer" | |||
| versionCode 1 | |||
| versionName "1.0" | |||
| minSdk 21 | |||
| minSdk 23 | |||
There was a problem hiding this comment.
should we comment why this is? bumping the minSdk on mobile seems discussion worthy.
There was a problem hiding this comment.
This came as a consequence of using Horologist on phone side.
There was a problem hiding this comment.
Yep - let me confirm why that is, so we can at least tell developers the root cause, why horologist is 23.
There was a problem hiding this comment.
Testing on google/horologist#2249
There was a problem hiding this comment.
will update when we release next Horologist version / or can wait to land until we do a Horologist release
There was a problem hiding this comment.
Maybe a Todo? And land now?
DataLayer/Wearable/src/main/java/com/example/android/wearable/datalayer/MainActivity.kt
Outdated
Show resolved
Hide resolved
DataLayer/Wearable/src/main/java/com/example/android/wearable/datalayer/MainActivity.kt
Outdated
Show resolved
Hide resolved
| displayNodes(nodes) | ||
| var nodeList: Set<Node>? = null | ||
| if (wearDataLayerAppHelper.isAvailable()) { | ||
| wearDataLayerAppHelper.connectedAndInstalledNodes.collect { nodes -> |
There was a problem hiding this comment.
Does this flow.collect ever return?
| // Increment the count to send next time | ||
| count++ | ||
| // Increment the count to send next time | ||
| count++ |
There was a problem hiding this comment.
I think this example is problematic. The count isn't stored or saved, so if there are reasons why the activity gets recreated it will revert to 0.
I think either
a) explain that the count is local to the specific instance of this activity and may reset
b) we use the DataClient as the current value and read and update the value.
The horologist sample might look more complicated with proto, and DataStore. But it's actually fundamentally a more real world example.
|
Closing this as decided to not use DataHelpers and demonstrate Wearable DataLayer library. Improvement for the sample is in #1116 |
No description provided.