Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axi_dmac_regmap_request.v: Updating assignment for up_dma_x_length. #1539

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

Villyam
Copy link
Contributor

@Villyam Villyam commented Dec 9, 2024

PR Description

  • The Lattice Radiant in the default configuration can not automatically infer the array size at concatenation.
  • I'm specifying the array size at concatenation to fix the error shown by Lattice Radiant.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

The Lattice Radiant in the default configuration can not
automatically infer the array size at concatenation.

Signed-off-by: Villyam <[email protected]>
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The shift assignment is to shift back the value set on line 122-123

  localparam DMAC_DEF_X_LENGTH_DEFAULT = !AUTORUN ? 'h00 :
    AUTORUN_X_LENGTH[DMA_LENGTH_WIDTH-1:DMA_LENGTH_ALIGN];

@Villyam Villyam merged commit a75d26c into main Dec 12, 2024
3 of 5 checks passed
@Villyam Villyam deleted the fix_assignment_axi_dmac branch December 12, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants