Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

projects/cn0561: Update SPIE project. FMC pinout. Software test #1188

Merged
merged 1 commit into from
Oct 18, 2023
Merged

projects/cn0561: Update SPIE project. FMC pinout. Software test #1188

merged 1 commit into from
Oct 18, 2023

Conversation

laurent-19
Copy link
Collaborator

@laurent-19 laurent-19 commented Oct 4, 2023 •
edited
Loading

PR Description

This PR covers the SPI Engine project checking and updates. Changes and additions include:

  • Added txt description of all FMC pins used/unused
  • Updated constraint files with FMC pinout location for Zed and Cora carrier boards

Hardware test with available software:

  • CN0561 NO-OS updated for new HDL design (PWM trigger for SPIE offload)
    • CN0561-Zed successful test - ADC conversion 1MHz ODR
    • CN0561-Cora failed test - 0V on ADC output channel

PR opened on NO-OS repo to introduce HDL design related changes. Merged into NO-OS master.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@laurent-19 laurent-19 requested review from StancaPop and a team October 4, 2023 10:25
@laurent-19
projects/cn0561: Add FMC pin descripton for all carriers
e575196 
* Added txt description of all FMC pins used/unused
* Updated constraint files with FMC pinout location

Signed-off-by: laurentiu_popa <[email protected]>
@laurent-19 laurent-19 force-pushed the update_cn0561_spi_engine branch from d5fec16 to e575196 Compare October 5, 2023 09:49
@laurent-19
Copy link
Collaborator Author

Removed fmc pins unused for the cn0561 spi.

PopPaul2021
PopPaul2021 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@PopPaul2021 PopPaul2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@laurent-19 laurent-19 merged commit 497a5f3 into master Oct 18, 2023
1 of 2 checks passed
@laurent-19 laurent-19 deleted the update_cn0561_spi_engine branch October 18, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PopPaul2021 PopPaul2021 PopPaul2021 approved these changes

@StancaPop StancaPop Awaiting requested review from StancaPop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurent-19 @PopPaul2021