Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pluto: Enable phaser integration #1184

Merged
merged 1 commit into from
Oct 6, 2023
Merged

pluto: Enable phaser integration #1184

merged 1 commit into from
Oct 6, 2023

Conversation

podgori
Copy link
Contributor

@podgori podgori commented Sep 28, 2023

PR Description

This commit adds support for ADALM-PHASER, allowing the user to choose between the default PlutoSDR mode and Phaser mode through a software controlled GPIO pin: phaser_enable.

The Generic TDD Engine was integrated to output a logic signal on the L10P pin, which connects to the input of the ADF4159, when receiving an external synchronization signal on the L12N pin from the Raspberry Pi. Two additional TDD channels are used to synchronize the TX/RX DMA transfer start.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

Comment on lines 66 to 72
# Pin | Package Pin | GPIO
# -----|-------------|---------
# L10P | K13 | PL_GPIO0
# L12N | M12 | PL_GPIO1
# L24N | R10 | PL_GPIO2
# L7N | N14 | PL_GPIO3
# L9N | M14 | PL_GPIO4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a couple of additional columns explaining typical connections for the GPIOs in the default Pluto firmware and when used with the CN0566

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as requested.

@podgori podgori force-pushed the pluto_phaser_master branch from 16aaeef to 39ec93f Compare October 4, 2023 14:02
@podgori
Copy link
Contributor Author

podgori commented Oct 4, 2023

Created a dedicated Pluto testbench here: https://github.com/analogdevicesinc/testbenches/tree/pluto_phaser_master

Copy link
Contributor

@acostina acostina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the whole text that you have in the Pull Request as part of the commit message, maybe even extending with the description of which output drives which DMA.
Other than that looks good.

This commit adds support for ADALM-PHASER, allowing the user to choose between the default PlutoSDR mode and Phaser mode
through a software controlled GPIO pin: phaser_enable.

The Generic TDD Engine was integrated to output a logic signal on the L10P pin, which connects to the input of the ADF4159,
when receiving an external synchronization signal on the L12N pin from the Raspberry Pi. Two additional TDD channels are used
to synchronize the TX/RX DMA transfer start:
- TDD CH1 is connected to the RX DMA, triggering the synchronization flag;
- TDD CH2 is connected to the TX unpacker's reset, backpressuring the TX DMA until deasserted.

Signed-off-by: Ionut Podgoreanu <[email protected]>
@podgori podgori force-pushed the pluto_phaser_master branch from 39ec93f to fb2ff89 Compare October 6, 2023 10:04
@podgori podgori merged commit 455bfbc into master Oct 6, 2023
1 of 2 checks passed
@podgori podgori deleted the pluto_phaser_master branch October 6, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants