Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set library by plugin #175

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Mar 1, 2024

Revert changes in #174.

Only adding a setting library plugin can update all events including default events' library.

  1. Change PUBLISH_VERSION in release.config.js to the latest semantic version
  2. build.gradle will then generate BuildConfig.java
  3. Set library in FlutterLibraryPlugin

Example BuildConfig.java

/**
 * Automatically generated file. DO NOT MODIFY
 */
package com.amplitude.amplitude_flutter;

public final class BuildConfig {
  public static final boolean DEBUG = Boolean.parseBoolean("true");
  public static final String LIBRARY_PACKAGE_NAME = "com.amplitude.amplitude_flutter";
  public static final String BUILD_TYPE = "debug";
  // Field from default config.
  public static final String SDK_VERSION = "4.0.0-beta.0";
}

Events include default events are set to amplitude-flutter/4.0.0-beta.0
https://app.amplitude.com/analytics/amplitude/project/471621/search/amplitude_id%3D842311306390?sessionHandle=Y38ZXvS_Y38ZXvS_MQdqoyW_BzJF_6ebbafb4-dc1d-4bd7-8ad7-0ff29dceed93R&eventId=98a9598b-1f8f-42a2-924a-20cfcb268b77

@Mercy811 Mercy811 requested a review from justin-fiedler March 4, 2024 17:05
@Mercy811 Mercy811 merged commit b9ecc6c into v4.x Mar 5, 2024
2 checks passed
@Mercy811 Mercy811 deleted the AMP-94598-add-set-library-plugin branch March 5, 2024 16:39
Copy link

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants