refactor: update iOS bridge #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mercy811
requested review from
izaaz,
justin-fiedler,
yuhao900914 and
qingzhuozhen
justin-fiedler
approved these changes
Mar 6, 2024
izaaz
approved these changes
Mar 6, 2024
| @@ -66,7 +65,7 @@ class AmplitudeFlutterPlugin : FlutterPlugin, MethodCallHandler, ActivityAware { | |||
| amplitude = Amplitude(configuration) | |||
|
|
|||
| // Set library | |||
| amplitude.add(FlutterLibraryPlugin()) | |||
| amplitude.add(FlutterLibraryPlugin(call.argument<String>("library")!!)) | |||
There was a problem hiding this comment.
nit: !! could maybe throw an error? what about this instead?
Suggested change
| amplitude.add(FlutterLibraryPlugin(call.argument<String>("library")!!)) | |
| amplitude.add(FlutterLibraryPlugin(call.argument<String>("library") ?? "amplitude-flutter/unknown")) |
There was a problem hiding this comment.
I like it! Update both Kotlin and Swift at 4eb9b6f
|
🎉 This PR is included in version 4.0.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ios/Classes/SwiftAmplitudeFlutterPlugin.swiftswiftlintto CIrelease.config.jshas to change package version for Flutter, Android (BuildConfig.SDK_VERSION`) and Swift plugins separatelyrelease.config.jsonly need to change package version for Flutterlibraryalong with configuration wheninit