-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize minor changes for v0.4 release #186
Conversation
Thanks @flferretti for these minor changes. @traversaro @flferretti I'd like to start discussing again about the lock file of pixi. I'm not happy with its size and the size of each modification that occur when it's re-rendered. As far as I understood, there is no real workaround. My proposal is the following:
The two benefits we get from this approach is that:
In general, if users clone the repository directly, the intended usage is creating the environment using the |
Ideally the nice thing of having the |
Sure, we can align f2f to make a decision. I like the |
@flferretti for the time being, can you remove the pixi lock file from this PR (with a force push, not a commit that reverts the modification). We will handle the lock file separately in a new PR after our f2f discussion. |
510a825
to
15564dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early review on this draft PR. Some comment on patterns used until now in JaxSim:
- When
jax.typing.ArrayLike
was used, it was mainly due my lazyness to specialize it to e.g.jtp.Float|jtp.Vector|jtp.Matrix
. TheLike
include plain python types and some more. If we are sure that it's going to be a jax numpy array, let's use the non-Like
versions. Note that it's long time I'm also planning to remove the*Jax
types in favour of the non-Like
ones. - If not necessary because it saves multiple conversions to
jaxlie
types, let's try to usejaxsim.math.*
resources in our codebase.
I'll add some commit as soon as you are done. Thanks!
08e10de
to
6c5fae5
Compare
6c5fae5
to
da3ff9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, last minor comments. Let me know when you're done and I might add last minor changes.
@flferretti I pushed few changes, let me know if you have any comment. Otherwise this PR on my side is ready. |
Thanks @diegoferigo, I'll wait for you to add the fixes for the CI and then I'll change the target branch of #187 to |
5925103
to
7f5aae2
Compare
Co-authored-by: Diego Ferigo <[email protected]>
Co-authored-by: Diego Ferigo <[email protected]>
Co-authored-by: Diego Ferigo <[email protected]>
This is necessary because the terrain is a static attribute of a model
7f5aae2
to
7036086
Compare
a5999d9
to
89c5056
Compare
This pull request adds minor fixes and updates in preparation for the new release.
@diegoferigo @xela-95 feel free to push similar changes.
📚 Documentation preview 📚: https://jaxsim--186.org.readthedocs.build//186/