Merge pull request #21 from aliyun/features/no_panic_seq

perf: not panic for sequence featureview using featuredb
aliyun · Jul 2, 2024 · 83db6ae · 83db6ae
2 parents 3dee591 + d0e9157
commit 83db6ae
Showing 1 changed file with 0 additions and 4 deletions.
diff --git a/domain/sequence_feature_view.go b/domain/sequence_feature_view.go
@@ -63,10 +63,6 @@ func NewSequenceFeatureView(view *api.FeatureView, p *Project, entity *FeatureEn
 		panic("deduplication_method invalid")
 	}
 
-	if p.OnlineDatasourceType == constants.Datasource_Type_FeatureDB || view.WriteToFeatureDB {
-		panic("sequence feature view not support featuredb yet")
-	}
-
 	daoConfig := dao.DaoConfig{
 		DatasourceType:  p.OnlineDatasourceType,
 		PrimaryKeyField: sequenceFeatureView.userIdField,