Skip to content

Commit

Permalink
perf: not panic for sequence featureview using featuredb
Browse files Browse the repository at this point in the history
  • Loading branch information
Yifshao committed Jul 1, 2024
1 parent 3dee591 commit d0e9157
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions domain/sequence_feature_view.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ func NewSequenceFeatureView(view *api.FeatureView, p *Project, entity *FeatureEn
panic("deduplication_method invalid")
}

if p.OnlineDatasourceType == constants.Datasource_Type_FeatureDB || view.WriteToFeatureDB {
panic("sequence feature view not support featuredb yet")
}

daoConfig := dao.DaoConfig{
DatasourceType: p.OnlineDatasourceType,
PrimaryKeyField: sequenceFeatureView.userIdField,
Expand Down

0 comments on commit d0e9157

Please sign in to comment.