2024 12 #65
Merged
2024 12 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alirezamirian
force-pushed
the
2024-12
branch
2 times, most recently
from
7fc3a51 to
9fffa35
Compare
feat(example-app): add editor context menu
alirezamirian
force-pushed
the
2024-12
branch
3 times, most recently
from
3698cf4 to
282c59f
Compare
…d the original one One of the addressed issues is adobe/react-spectrum#1842 which is [fixed](adobe/react-spectrum#1843) already. The other issue is adobe/react-spectrum#4391 which is possible to work around in a wrapper.
Since @react-aria/[email protected] getKeyLeftOf and getKeyRightOf is removed if orientation is vertical and layout is "stack". Using the single-argument overload of the base constructor doesn't set a default value for orientation (which seems a little random), which in turn makes the if statement that removes the methods not run. https://github.com/adobe/react-spectrum/blob/8228e4efd9be99973058a1f90fc7f7377e673f78/packages/%40react-aria/selection/src/ListKeyboardDelegate.ts#L67
if `title` is set on `Item`, the default getItemCollection method assumes the item's children contain child nodes, and sets hasChildNodes to `true`.
…collection component useCollectionSearchInput had this advantage of allowing for connecting an input to ANY collection without requiring support from the collection component. However the collection component needed to support selectionManagerRef, so there was still a need to make the collection component compatible with useCollectionSearchInput. Plus, the usage API isn't simple enough, as it requires: - creating a ref to hold selection manager. Passing that ref to selectionManagerRef, and importing the right type for the ref value. - importing and invoking useCollectionSearchInput, and applying the returned props on the connected input. That's a lot of not-so-intuitive work. Considering any supported collection component still needs to support `CollectionRefProps` and utilize `useCollectionRef` to support connected input, the implementation is changed to have the event listeners baked into the collections (via a new useCollectionFocusProxy hook). This way at least the usage API is as simple as passing a ref to the connected input to `focusProxyRef` prop of the collection component.
(uncaught exception)TypeError: Cannot read properties of null (reading 'scrollTop') caused only when running tests on CI pipeline. Due to ref being null, which is safe-guarded with optional chaining in @react-aria/[email protected] https://cloud.cypress.io/projects/o1ooqz/runs/253/test-results/f5726287-8ab4-4441-836b-763b32845987/replay?actions=%5B%5D&browsers=%5B%5D&groups=%5B%5D&isFlaky=%5B%5D&modificationDateRange=%7B%22startDate%22%3A%221970-01-01%22%2C%22endDate%22%3A%222038-01-19%22%7D&orderBy=EXECUTION_ORDER&oses=%5B%5D&specs=%5B%5D&statuses=%5B%7B%22value%22%3A%22FAILED%22%2C%22label%22%3A%22FAILED%22%7D%5D&testingTypesEnum=%5B%5D&ts=1733774625108.0454&utm_source=github&att=1
alirezamirian
force-pushed
the
2024-12
branch
from
282c59f to
c2f1fce
Compare
JUI
|
||||||||||||||||||||||||||||
| Project |
JUI
|
| Branch Review |
2024-12
|
| Run status |
|
| Run duration | 02m 47s |
| Commit |
|
| Committer | Alireza Mirian |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
7
|
Skipped
|
0
|
Passing
|
340
|
| View all changes introduced in this branch ↗︎ | |
Trying a little wait between finding the menu in the dom and scrolling, just in case the scroll handlers inside menu overlay are set up with a tiny delay. Doesn't seem that plausible though.
alirezamirian
force-pushed
the
2024-12
branch
from
d504950 to
c30fdd5
Compare
For some unknown reason, scroll events were triggered upon mouse wheel, even though scroll was prevented. It didn't happen when running locally headless with `cypress run`, so it seems like the only differentiating factor is the OS being linux in the CI env. The test is changed to compare actual scrollY of the window, instead of checking if scroll event handlers are called.
alirezamirian
force-pushed
the
2024-12
branch
from
4255b0a to
b3123b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.