upgrade @react-aria/selection to prevent a random error in running tests

(uncaught exception)TypeError: Cannot read properties of null (reading 'scrollTop') caused only when running tests on CI pipeline. Due to ref being null, which is safe-guarded with optional chaining in @react-aria/[email protected] https://cloud.cypress.io/projects/o1ooqz/runs/253/test-results/f5726287-8ab4-4441-836b-763b32845987/replay?actions=%5B%5D&browsers=%5B%5D&groups=%5B%5D&isFlaky=%5B%5D&modificationDateRange=%7B%22startDate%22%3A%221970-01-01%22%2C%22endDate%22%3A%222038-01-19%22%7D&orderBy=EXECUTION_ORDER&oses=%5B%5D&specs=%5B%5D&statuses=%5B%7B%22value%22%3A%22FAILED%22%2C%22label%22%3A%22FAILED%22%7D%5D&testingTypesEnum=%5B%5D&ts=1733774625108.0454&utm_source=github&att=1
alirezamirian · Dec 9, 2024 · 282c59f · 282c59f
1 parent 9399788
commit 282c59f
Show file tree

Hide file tree

Showing 3 changed files with 141 additions and 161 deletions.
diff --git a/packages/jui/package.json b/packages/jui/package.json
@@ -45,24 +45,24 @@
     "@react-aria/checkbox": "~3.3.4",
     "@react-aria/combobox": "^3.10.3",
     "@react-aria/dialog": "~3.2.1",
-    "@react-aria/focus": "~3.18.1",
-    "@react-aria/i18n": "^3.12.1",
-    "@react-aria/interactions": "~3.22.1",
+    "@react-aria/focus": "~3.19.0",
+    "@react-aria/i18n": "^3.12.4",
+    "@react-aria/interactions": "~3.22.5",
     "@react-aria/label": "~3.7.10",
     "@react-aria/link": "~3.2.5",
     "@react-aria/listbox": "~3.12.1",
     "@react-aria/menu": "~3.14.1",
     "@react-aria/overlays": "~3.23.1",
     "@react-aria/progress": "~3.1.8",
     "@react-aria/select": "~3.14.7",
-    "@react-aria/selection": "~3.18.1",
+    "@react-aria/selection": "~3.21.0",
     "@react-aria/separator": "~3.1.7",
     "@react-aria/tabs": "~3.1.5",
     "@react-aria/tooltip": "~3.3.4",
     "@react-aria/utils": "~3.25.1",
     "@react-aria/virtualizer": "3.3.7",
     "@react-aria/visually-hidden": "~3.8.14",
-    "@react-stately/collections": "~3.10.9",
+    "@react-stately/collections": "~3.12.0",
     "@react-stately/combobox": "^3.9.2",
     "@react-stately/layout": "3.4.4",
     "@react-stately/list": "~3.10.7",
@@ -77,7 +77,7 @@
     "@react-stately/utils": "~3.10.2",
     "@react-stately/virtualizer": "~3.1.9",
     "@react-types/menu": "~3.9.11",
-    "@react-types/shared": "~3.24.1",
+    "@react-types/shared": "~3.26.0",
     "@swc/helpers": "~0.3.17",
     "ramda": "~0.27.2"
   },

diff --git a/packages/jui/src/Tree/TreeKeyboardDelegate.tsx b/packages/jui/src/Tree/TreeKeyboardDelegate.tsx
@@ -20,12 +20,12 @@ export class TreeKeyboardDelegate<T> extends ListKeyboardDelegate<T> {
     });
   }
 
-  getKeyLeftOf(key: React.Key): React.Key {
+  getKeyLeftOf(key: React.Key): React.Key | null {
     const item = this.collection.getItem(key);
     return item?.parentKey ?? this.getKeyAbove(key);
   }
 
-  getKeyRightOf(key: React.Key): React.Key {
+  getKeyRightOf(key: React.Key): React.Key | null {
     return this.getKeyBelow(key);
   }
 }