Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create new scribe parser that uses top and bottom #509

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

AlxEnashi
Copy link
Contributor

Summary of the changes

the scribe parser code y replicated between 3 classes now. There must be a better way to make this more mantainable.

Observations

<-- Add some notes to keep in mind !-->

If the change is BREAKING, please give more details about the breaking changes

<-- What change breaks what and how !-->

Components that need updates and steps to follow

<-- Link repos or other PRs !-->

About this PR:

  • You added the necessary documentation for the team to understand your work.
  • You linked this PR to the corresponding issue or user story.
  • Your changes fulfill the Definition of Done of the issue or user story.
  • Your changes were tested with manual testing before being submitted.
  • Your changes were tested with automatic unit tests.
  • Your changes were tested with automatic integration tests.

Screensshots

<-- Add some screenshots if necessary !-->

@AlxEnashi AlxEnashi merged commit ed30cad into main Dec 2, 2024
7 of 8 checks passed
@AlxEnashi AlxEnashi deleted the feat/sending_top_bottom_classifications branch December 2, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant