Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrigindo bug #1217 #1

Open
wants to merge 93 commits into
base: feature/multiple_downloads
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
543e88f
Added timeCreated field to DownloadTask
781flyingdutchman Feb 22, 2020
417574a
Added timeCreated in loadTasksWithRawQuery
781flyingdutchman Feb 22, 2020
0b3a6db
Updated .gitignore
781flyingdutchman Feb 23, 2020
da4029f
Updated another .gitignore
781flyingdutchman Feb 23, 2020
7b03054
Removed two generated files from git cache that should not be checked…
781flyingdutchman Feb 23, 2020
70499e1
Corrected error
781flyingdutchman Feb 23, 2020
94c5728
Merge pull request #247 from 781flyingdutchman/master
hnvn Mar 26, 2020
e8bcfc5
To support use from isolation, do not use singleton.
addie9000 Mar 26, 2020
112b940
Addressing compiler warnings
781flyingdutchman Mar 29, 2020
49e9d88
Making currentTimeInMilliseconds a long long instead of a long
781flyingdutchman Mar 29, 2020
b511a15
Fixing critical issue in removeMethodCall
781flyingdutchman Mar 29, 2020
667ffaf
Merge pull request #273 from initig/support_isolate_ios
hnvn Apr 2, 2020
541cbc6
release v1.4.2
hnvn Apr 2, 2020
01f837c
release v1.4.2
hnvn Apr 2, 2020
f8aa95f
Merge pull request #271 from 781flyingdutchman/pullrequest
hnvn Apr 9, 2020
d74efef
release v1.4.3
hnvn Apr 9, 2020
87ae257
upgrade Android dependencies
hnvn Apr 18, 2020
b0d3544
add log config for Android, fix issue caused Skia complained (cannot …
hnvn Apr 18, 2020
093b201
add log config for Android, fix issue caused Skia complained (cannot …
hnvn Apr 18, 2020
40cb0f2
add log config for iOS
hnvn Apr 18, 2020
87b8fa4
add log config for iOS
hnvn Apr 18, 2020
e344303
update document
hnvn Apr 18, 2020
d4d5ab5
Merge pull request #1 from fluttercommunity/master
atrope Apr 25, 2020
05f8df7
Merge branch 'master' into feature/multiple_downloads
atrope Apr 25, 2020
2449bc8
Make download progress step size configurable, not just every 10%.
Apr 28, 2020
53db362
Adding file to Media Center when downloaded/remove
atrope May 13, 2020
fbb3362
forgot plugin import
atrope May 13, 2020
68691c9
Also removes for iOS
atrope May 13, 2020
649c9c9
Update enqueue Item/Items to async
atrope Jun 23, 2020
e4f4826
Android 10+ Save on another apps
atrope Jul 12, 2020
f8613f9
fixing scan for older Androids
atrope Jul 14, 2020
a793ed9
checking if file exists in first place..
atrope Jul 24, 2020
bc47975
migrate to new pubspec format
hnvn Aug 9, 2020
4898fea
update new Podfile
hnvn Aug 9, 2020
975b5ae
upgrade Android dependencies
hnvn Aug 9, 2020
a2f2570
refactor example codes
hnvn Aug 9, 2020
82e118c
release v1.5.0
hnvn Aug 9, 2020
1209d24
Update FlutterDownloaderPlugin.m
nimisis Aug 18, 2020
ebb8634
Merge pull request #3 from fluttercommunity/master
atrope Aug 19, 2020
b85d03e
Merge branch 'master' into feature/multiple_downloads
atrope Aug 19, 2020
ef38a03
adding new field for reporting
atrope Aug 20, 2020
3d8af80
Merge pull request #285 from nimisis/master
hnvn Aug 23, 2020
cd5db7d
Revert "Make download progress step size configurable, not just every…
hnvn Aug 23, 2020
f219610
Merge pull request #334 from fluttercommunity/revert-285-master
hnvn Aug 23, 2020
edd20e5
user agent
atrope Aug 25, 2020
77eaa3f
adding headers to resume and retry
atrope Aug 26, 2020
46165b7
Added not condition for registering plugin
mrinaljain Sep 24, 2020
57492e4
Merge pull request #347 from mrinaljain/patch-1
hnvn Sep 24, 2020
4de922a
fixing invalid array position
atrope Sep 24, 2020
53fd826
Fix iOS not updating progress while downloading file
alhafoudh Sep 25, 2020
e67a123
Merge pull request #350 from alhafoudh/fix-progress-ios
hnvn Sep 26, 2020
7e68111
release v1.5.1
hnvn Sep 27, 2020
3b28fd5
Add fields music artist and music album as download intent extras
lalbuquerque Sep 29, 2020
8118117
Add fields album and artist to TaskContract
lalbuquerque Sep 30, 2020
1e1358d
Add new columns (album and artist) to DB and increase DATABASE_VERSION
lalbuquerque Sep 30, 2020
e3001e5
Update methods signatures to use album and artist fields
lalbuquerque Sep 30, 2020
673b8c6
Search for album and artist fields when receiving an enqueue or enque…
lalbuquerque Sep 30, 2020
bda7f97
Add albumName and artistName to DownloadTask
lalbuquerque Sep 30, 2020
bca0dfd
Update with new fields (albumName and artistName)
lalbuquerque Sep 30, 2020
46fd419
Update enqueue method signature with new music fields (albumName and …
lalbuquerque Sep 30, 2020
06844ee
Add new field sm_extras to android module DB and Media Store (on Book…
lalbuquerque Oct 2, 2020
f389d04
Add field sm_extras to API layer
lalbuquerque Oct 2, 2020
57f8200
Remove space to fix DB creation
lalbuquerque Oct 5, 2020
350bcea
Fix DownloadItem.toMap() method
lalbuquerque Oct 5, 2020
06875a2
Fix smExtras data type and encoding
lalbuquerque Oct 5, 2020
4556324
Improve parameters log
lalbuquerque Oct 8, 2020
c27b06d
Add DB migration version 3
lalbuquerque Oct 8, 2020
fa0b1f5
Merge pull request #4 from SuaMusica/feature/save_music_info_on_media…
lalbuquerque Oct 9, 2020
4f6aa11
Merge pull request #5 from fluttercommunity/master
atrope Oct 12, 2020
c62f23b
Merge branch 'master' into feature/multiple_downloads
atrope Oct 12, 2020
c4e60a5
Insert artist name on column MediaStore.Audio.Media.ALBUM_ARTIST too
lalbuquerque Oct 17, 2020
caf833b
Merge pull request #6 from SuaMusica/fill_album_artist_column_on_medi…
atrope Oct 19, 2020
49332f6
add codes to remove file in media store DB
hnvn Oct 25, 2020
8ab8f7d
fix bug notification stuck in processing on Android
hnvn Oct 25, 2020
3842c18
Extend MediaStore support for all APIs above 22 and remove BOOKMARK i…
lalbuquerque Oct 28, 2020
df07217
Merge pull request #7 from SuaMusica/feature/extend_mediastore_api_su…
atrope Oct 28, 2020
f863180
Merge pull request #8 from fluttercommunity/master
atrope Oct 31, 2020
1cff303
Save SM extras on id3 through custom tags and comments
lalbuquerque Nov 2, 2020
6a48aac
Merge branch 'master' into feature/multiple_downloads
atrope Nov 3, 2020
f24dfcc
auto cancel Complete Notification
atrope Nov 3, 2020
d785221
[WIP] Fixing MP3 file ID3 tags
Nov 4, 2020
b7bb1a9
Fixing sm-related arguments
Nov 4, 2020
a0b4bcd
Fixing bug
Nov 4, 2020
c140105
Merge branch 'feature/multiple_downloads' into save_extras_on_id3
lalbuquerque Nov 5, 2020
cd04ee2
Removing line
Nov 8, 2020
194b1d1
Merge branch 'save_extras_on_id3' of github.com:SuaMusica/flutter_dow…
Nov 8, 2020
13c53c8
Merge pull request #9 from SuaMusica/save_extras_on_id3
atrope Nov 16, 2020
d567824
try Alter Table
atrope Nov 20, 2020
5c718c9
fix if alter table
atrope Nov 20, 2020
66665aa
fixing if contenttype was wrong.
atrope Jan 14, 2021
4859b46
Fixing issue #1217
Mar 4, 2021
5b8765a
Fixing issue #1217
Mar 4, 2021
265b0dd
Merge branch 'hotfix/#1217' of github.com:SuaMusica/flutter_downloade…
Mar 4, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Save SM extras on id3 through custom tags and comments
  • Loading branch information
lalbuquerque committed Nov 2, 2020
commit 1cff303f4bc22b72e0937535539ef4fc92cc7d91
1 change: 1 addition & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
@@ -38,4 +38,5 @@ dependencies {
implementation 'androidx.annotation:annotation:1.1.0'
implementation 'androidx.core:core:1.3.1'
implementation 'androidx.fragment:fragment:1.2.5'
implementation 'com.mpatric:mp3agic:0.9.0'
}
Original file line number Diff line number Diff line change
@@ -50,6 +50,13 @@
import androidx.work.Worker;
import androidx.work.WorkerParameters;

import com.mpatric.mp3agic.ID3v1Tag;
import com.mpatric.mp3agic.ID3v24Tag;
import com.mpatric.mp3agic.InvalidDataException;
import com.mpatric.mp3agic.Mp3File;
import com.mpatric.mp3agic.NotSupportedException;
import com.mpatric.mp3agic.UnsupportedTagException;

import io.flutter.plugin.common.MethodCall;
import io.flutter.plugin.common.MethodChannel;
import io.flutter.plugin.common.PluginRegistry;
@@ -639,6 +646,15 @@ private void addMediaToGallery(String fileName, String filePath, String contentT
values.put(MediaStore.Audio.Media.ALBUM, argMusicAlbum);
values.put(MediaStore.Audio.Media.BOOKMARK, argSMExtras);

try {
Mp3File mp3File = new Mp3File(filePath);
ID3v1Tag id3v1Tag = new ID3v1Tag();
id3v1Tag.setComment(argSMExtras);
mp3File.setId3v1Tag(id3v1Tag);
mp3File.setCustomTag(argSMExtras.getBytes());
} catch (IOException | UnsupportedTagException | InvalidDataException e) {
e.printStackTrace();
}
// For reasons I could not understand, Android SDK is failing to find the
// constant MediaStore.Audio.Media.ALBUM_ARTIST in pre-compilation time and
// obligated me to reference the column string value.