Corrigindo bug #1217 #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into source control
Used () where I should have used [] to get time_created from the [item] map
Added timeCreated to the DownloadTask class
Issue: if loadTaskWithId pulls the task from the database (not the cache) and if that task is enqueued or running, then getTaskWithCompletionHandler may not have that task as part of its list of downloadTasks (because it may have been started a long time ago and gotten lost as the app was killed). In that case, the taskId will not be found in the list, and therefore the task will not be removed from the database. As a result, the\ sqlite database can get polluted with tasks that cannot be removed ever. Fix: call [self deleteTask:taskId] unconditionally after the if-statement (that checks for enqueue or running) instead of only in the 'else' clause of that if-statement
To support use from isolation, do not use singleton. (iOS)
…quest Critical fix to removeMethodCall
…load bitmap in notification config step)
…load bitmap in notification config step)
Update Master
…_store Save music album and artist on MediaStore
update from master 1.5.1
…a_store Insert artist name on column MediaStore.Audio.Media.ALBUM_ARTIST too
…pport Extend mediastore API support
Merge from master
…nloader into save_extras_on_id3
Save extras on id3
…r into hotfix/#1217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Para corrigir o bug #1217 (OneApp), o taskId retornado na task não pode ser somente o id.
Eu acho que o criador do plugin fez um pequeno erro quando estava pegando o taskId. Esse change corrige esse erro.