Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample: Dialect config in samples #1066

Merged
merged 1 commit into from
Nov 10, 2023
Merged

sample: Dialect config in samples #1066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions samples/grpc/shopping-analytics-service-java/src/main/resources/persistence.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
akka.persistence.r2dbc.connection-factory = ${akka.persistence.r2dbc.postgres}
akka {
persistence {
journal {
Expand All @@ -7,19 +8,13 @@ akka {
plugin = "akka.persistence.r2dbc.snapshot"
}
r2dbc {
# yugabyte or postgres
dialect = "postgres"
connection-factory {
driver = "postgres"

host = "localhost"
host = ${?DB_HOST}

port = 5432
database = "postgres"
user = "postgres"
user = ${?DB_USER}

password = "postgres"
password = ${?DB_PASSWORD}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: All these are defaults so it would also be possible to just add the maybe-env-entries and use the others from default config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

um maybe, I think it's fine to repeat them for clarity here
e.g. I see what I can use with my psql without having to look at reference.conf

}
Expand Down
7 changes: 1 addition & 6 deletions samples/grpc/shopping-analytics-service-scala/src/main/resources/persistence.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
akka.persistence.r2dbc.connection-factory = ${akka.persistence.r2dbc.postgres}
akka {
persistence {
journal {
Expand All @@ -7,19 +8,13 @@ akka {
plugin = "akka.persistence.r2dbc.snapshot"
}
r2dbc {
# yugabyte or postgres
dialect = "postgres"
connection-factory {
driver = "postgres"

host = "localhost"
host = ${?DB_HOST}

port = 5432
database = "postgres"
user = "postgres"
user = ${?DB_USER}

password = "postgres"
password = ${?DB_PASSWORD}
}
Expand Down
2 changes: 0 additions & 2 deletions samples/grpc/shopping-analytics-service-scala/src/main/resources/serialization.conf
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions samples/grpc/shopping-cart-service-java/src/main/resources/persistence.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
akka.persistence.r2dbc.connection-factory = ${akka.persistence.r2dbc.postgres}
akka {
persistence {
journal {
Expand All @@ -7,11 +8,7 @@ akka {
plugin = "akka.persistence.r2dbc.snapshot"
}
r2dbc {
# yugabyte or postgres
dialect = "postgres"
connection-factory {
driver = "postgres"

host = "localhost"
host = ${?DB_HOST}
port = 5432
Expand Down
5 changes: 1 addition & 4 deletions samples/grpc/shopping-cart-service-scala/src/main/resources/persistence.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
akka.persistence.r2dbc.connection-factory = ${akka.persistence.r2dbc.postgres}
akka {
persistence {
journal {
Expand All @@ -7,11 +8,7 @@ akka {
plugin = "akka.persistence.r2dbc.snapshot"
}
r2dbc {
# yugabyte or postgres
dialect = "postgres"
connection-factory {
driver = "postgres"

host = "localhost"
host = ${?DB_HOST}
port = 5432
Expand Down
5 changes: 1 addition & 4 deletions samples/replicated/shopping-cart-service-java/src/main/resources/persistence.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
akka.persistence.r2dbc.connection-factory = ${akka.persistence.r2dbc.postgres}
akka {
persistence {
journal {
Expand All @@ -7,11 +8,7 @@ akka {
plugin = "akka.persistence.r2dbc.snapshot"
}
r2dbc {
# yugabyte or postgres
dialect = "postgres"
connection-factory {
driver = "postgres"

host = "localhost"
host = ${?DB_HOST}
port = 5432
Expand Down
5 changes: 1 addition & 4 deletions samples/replicated/shopping-cart-service-scala/src/main/resources/persistence.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
akka.persistence.r2dbc.connection-factory = ${akka.persistence.r2dbc.postgres}
akka {
persistence {
journal {
Expand All @@ -7,11 +8,7 @@ akka {
plugin = "akka.persistence.r2dbc.snapshot"
}
r2dbc {
# yugabyte or postgres
dialect = "postgres"
connection-factory {
driver = "postgres"

host = "localhost"
host = ${?DB_HOST}
port = 5432
Expand Down