sample: Dialect config in samples #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
patriknw
commented
Nov 9, 2023
patriknw
commented
- seems we forgot to update these
* seems we forgot to update these
johanandren
approved these changes
Nov 9, 2023
| port = 5432 | ||
| database = "postgres" | ||
| user = "postgres" | ||
| user = ${?DB_USER} | ||
|
|
||
| password = "postgres" | ||
| password = ${?DB_PASSWORD} |
There was a problem hiding this comment.
Just a note: All these are defaults so it would also be possible to just add the maybe-env-entries and use the others from default config.
There was a problem hiding this comment.
um maybe, I think it's fine to repeat them for clarity here
e.g. I see what I can use with my psql without having to look at reference.conf
|
This might deserve an additional doc publish since the samples are broken. Let's see if we have another reason for a real release next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.