Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test to check that bar graph makes requests with size 1 (limit=1). #470

Merged
merged 16 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions example/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,5 +105,6 @@ const openmct = window.openmct;
);

openmct.install(openmct.plugins.FaultManagement());
openmct.install(openmct.plugins.BarChart());
}
})();
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"lint:fix": "eslint src example --fix",
"build:dist": "webpack --config ./.webpack/webpack.prod.mjs",
"build:example": "npm install openmct@unstable --no-save",
"build:example:master": "npm install nasa/openmct --no-save",
"build:example:master": "npm install nasa/openmct#bar-graph-historical-requests --no-save",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

"postbuild:example": "node check-optional-dependencies.mjs",
"start": "npx webpack serve --config ./.webpack/webpack.dev.mjs",
"start:coverage": "npx webpack serve --config ./.webpack/webpack.coverage.mjs",
Expand Down
101 changes: 101 additions & 0 deletions tests/e2e/yamcs/barGraph.e2e.spec.mjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
/*****************************************************************************
* Open MCT, Copyright (c) 2014-2024, United States Government
* as represented by the Administrator of the National Aeronautics and Space
* Administration. All rights reserved.
*
* Open MCT is licensed under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* http://www.apache.org/licenses/LICENSE-2.0.
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
* License for the specific language governing permissions and limitations
* under the License.
*
* Open MCT includes source code licensed under additional open source
* licenses. See the Open Source Licenses file (LICENSES.md) included with
* this source code distribution or the Licensing information page available
* at runtime from the About dialog for additional information.
*****************************************************************************/

/*
* This test suite is dedicated to testing the Bar Graph component.
*/

import { pluginFixtures, appActions } from 'openmct-e2e';
const { test, expect } = pluginFixtures;
const { createDomainObjectWithDefaults } = appActions;

test.describe('Bar Graph', () => {
let barGraph;
let networkRequests = [];
let historicalGet;

test.beforeEach(async ({ page }) => {
// Open a browser, navigate to the main page, and wait until all networkevents to resolve
await page.goto('./', { waitUntil: 'domcontentloaded' });

// Create the Bar Graph
barGraph = await createDomainObjectWithDefaults(page, { type: 'Graph' });
});

test('Requests a single historical datum', async ({ page }) => {
shefalijoshi marked this conversation as resolved.
Show resolved Hide resolved
//Expand the myproject folder (/myproject)
const myProjectTreeItem = page.locator('.c-tree__item').filter({ hasText: 'myproject'});
const firstMyProjectTriangle = myProjectTreeItem.first().locator('span.c-disclosure-triangle');
shefalijoshi marked this conversation as resolved.
Show resolved Hide resolved
await firstMyProjectTriangle.click();

//Expand the myproject under the previous folder (/myproject/myproject)
const viperRoverTreeItem = page.locator('.c-tree__item').filter({ hasText: 'myproject'});
const viperRoverProjectTriangle = viperRoverTreeItem.nth(1).locator('span.c-disclosure-triangle');
await viperRoverProjectTriangle.click();

//Find the Magnetometer parameter (/myproject/myproject/Magnetometer)
const magnetometerTreeItem = page.getByRole('treeitem', { name: /Magnetometer/ });

networkRequests = [];
historicalGet = page.waitForRequest('**/api/archive/myproject/parameters/**');

//Drag and drop the Magnetometer telemetry endpoint into this bar graph
await magnetometerTreeItem.dragTo(page.getByLabel('Object View'));

// Save (exit edit mode)
await page.getByLabel('Save').click();
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click();

const historicalRequest = await historicalGet;
await expect(historicalRequest.url()).toContain('limit=1');
});
});

/**
* Util for returning the size option for telemetry requests
* @param {import('@playwright/test').Page} page
*/
async function addTelemetryInterceptor(page) {
const getRequestOptionsPromise = new Promise((resolve) =>
page.exposeFunction('getRequestOptions', resolve)
);

await page.evaluate(() => {
function requestOptionsChecker() {
return {
appliesTo: () => {
return true;
},
invoke: (request) => {
window.getRequestOptions({
strategy: request.strategy,
size: request.size
});
return request;
}
};
}
window.openmct.telemetry.addRequestInterceptor(requestOptionsChecker());
});

return getRequestOptionsPromise;
}
Loading