-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to check that bar graph makes requests with size 1 (limit=1). #470
Merged
Merged
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
9f622e8
Include Graphs in default plugins installed.
shefalijoshi ddcf004
Remove unnecessary page.goto.
shefalijoshi e88a746
Use request url for checking query parameters
shefalijoshi ad95528
Small locator changes
shefalijoshi 058b766
Merge branch 'master' into bar-graph-historical-requests
unlikelyzero 3afa3ed
Fix locators
shefalijoshi 0d81584
Merge branch 'master' of https://github.com/akhenry/openmct-yamcs int…
shefalijoshi f62b4c5
Standardize request parameter checks
shefalijoshi c9e1b5a
Merge branch 'master' into bar-graph-historical-requests
unlikelyzero 716ccfc
Update logic to properly detect branch
unlikelyzero 59676cd
update test to match new appActions layout
unlikelyzero c799dda
add a yamcs appAction file
unlikelyzero 4ffd828
remove temp
unlikelyzero fccdd6a
update documentation
unlikelyzero ecfe013
Clean up clean
unlikelyzero b491a90
address review comments
unlikelyzero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,101 @@ | ||
/***************************************************************************** | ||
* Open MCT, Copyright (c) 2014-2024, United States Government | ||
* as represented by the Administrator of the National Aeronautics and Space | ||
* Administration. All rights reserved. | ||
* | ||
* Open MCT is licensed under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* http://www.apache.org/licenses/LICENSE-2.0. | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
* License for the specific language governing permissions and limitations | ||
* under the License. | ||
* | ||
* Open MCT includes source code licensed under additional open source | ||
* licenses. See the Open Source Licenses file (LICENSES.md) included with | ||
* this source code distribution or the Licensing information page available | ||
* at runtime from the About dialog for additional information. | ||
*****************************************************************************/ | ||
|
||
/* | ||
* This test suite is dedicated to testing the Bar Graph component. | ||
*/ | ||
|
||
import { pluginFixtures, appActions } from 'openmct-e2e'; | ||
const { test, expect } = pluginFixtures; | ||
const { createDomainObjectWithDefaults } = appActions; | ||
|
||
test.describe('Bar Graph', () => { | ||
let barGraph; | ||
let networkRequests = []; | ||
let historicalGet; | ||
|
||
test.beforeEach(async ({ page }) => { | ||
// Open a browser, navigate to the main page, and wait until all networkevents to resolve | ||
await page.goto('./', { waitUntil: 'domcontentloaded' }); | ||
|
||
// Create the Bar Graph | ||
barGraph = await createDomainObjectWithDefaults(page, { type: 'Graph' }); | ||
}); | ||
|
||
test('Requests a single historical datum', async ({ page }) => { | ||
shefalijoshi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
//Expand the myproject folder (/myproject) | ||
const myProjectTreeItem = page.locator('.c-tree__item').filter({ hasText: 'myproject'}); | ||
const firstMyProjectTriangle = myProjectTreeItem.first().locator('span.c-disclosure-triangle'); | ||
shefalijoshi marked this conversation as resolved.
Show resolved
Hide resolved
|
||
await firstMyProjectTriangle.click(); | ||
|
||
//Expand the myproject under the previous folder (/myproject/myproject) | ||
const viperRoverTreeItem = page.locator('.c-tree__item').filter({ hasText: 'myproject'}); | ||
const viperRoverProjectTriangle = viperRoverTreeItem.nth(1).locator('span.c-disclosure-triangle'); | ||
await viperRoverProjectTriangle.click(); | ||
|
||
//Find the Magnetometer parameter (/myproject/myproject/Magnetometer) | ||
const magnetometerTreeItem = page.getByRole('treeitem', { name: /Magnetometer/ }); | ||
|
||
networkRequests = []; | ||
historicalGet = page.waitForRequest('**/api/archive/myproject/parameters/**'); | ||
|
||
//Drag and drop the Magnetometer telemetry endpoint into this bar graph | ||
await magnetometerTreeItem.dragTo(page.getByLabel('Object View')); | ||
|
||
// Save (exit edit mode) | ||
await page.getByLabel('Save').click(); | ||
await page.getByRole('listitem', { name: 'Save and Finish Editing' }).click(); | ||
|
||
const historicalRequest = await historicalGet; | ||
await expect(historicalRequest.url()).toContain('limit=1'); | ||
}); | ||
}); | ||
|
||
/** | ||
* Util for returning the size option for telemetry requests | ||
* @param {import('@playwright/test').Page} page | ||
*/ | ||
async function addTelemetryInterceptor(page) { | ||
const getRequestOptionsPromise = new Promise((resolve) => | ||
page.exposeFunction('getRequestOptions', resolve) | ||
); | ||
|
||
await page.evaluate(() => { | ||
function requestOptionsChecker() { | ||
return { | ||
appliesTo: () => { | ||
return true; | ||
}, | ||
invoke: (request) => { | ||
window.getRequestOptions({ | ||
strategy: request.strategy, | ||
size: request.size | ||
}); | ||
return request; | ||
} | ||
}; | ||
} | ||
window.openmct.telemetry.addRequestInterceptor(requestOptionsChecker()); | ||
}); | ||
|
||
return getRequestOptionsPromise; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here