Test to check that bar graph makes requests with size 1 (limit=1). #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test to check that bar graph makes requests with size 1 (limit=1).
Move waitForResponse to just before telemetry is added to the graph
unlikelyzero
requested changes
Sep 10, 2024
…o bar-graph-historical-requests
akhenry
previously requested changes
Sep 11, 2024
package.json
Outdated
| @@ -20,7 +20,7 @@ | |||
| "lint:fix": "eslint src example --fix", | |||
| "build:dist": "webpack --config ./.webpack/webpack.prod.mjs", | |||
| "build:example": "npm install openmct@unstable --no-save", | |||
| "build:example:master": "npm install nasa/openmct --no-save", | |||
| "build:example:master": "npm install nasa/openmct#bar-graph-historical-requests --no-save", | |||
|
|
||
| // Create the Bar Graph | ||
| barGraph = await createDomainObjectWithDefaults(page, { type: 'Graph', name: 'Bar Graph' }); | ||
| // Enter edit mode for the overlay plot |
There was a problem hiding this comment.
Link 'Magnetometer' to barGraph
tests/e2e/yamcsAppActions.mjs
Outdated
| /** | ||
| * Search for telemetry and link it to an object. objectName should come from the domainObject.name function. | ||
| * @param {import('@playwright/test').Page} page | ||
| * @param {string} telemetryText |
There was a problem hiding this comment.
rename to parameterNameText?
unlikelyzero
approved these changes
Sep 25, 2024
ozyx
previously requested changes
Sep 25, 2024
tests/e2e/yamcsAppActions.mjs
Outdated
| /** | ||
| * Search for telemetry and link it to an object. objectName should come from the domainObject.name function. | ||
| * @param {import('@playwright/test').Page} page | ||
| * @param {string} telemetryText |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes nasa/openmct#7811
Describe your changes:
Include Graphs in default plugins installed.
Test to check that bar graph makes requests with size 1 (limit=1)
All Submissions:
Author Checklist
type:label? Note: this is not necessarily the same as the original issue.Reviewer Checklist