-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix safari pop-up issue with new LinkButton
widget
#1011
Fix safari pop-up issue with new LinkButton
widget
#1011
Conversation
0ba49d5
to
c43a43b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
+ Coverage 69.10% 69.17% +0.07%
==========================================
Files 117 117
Lines 6499 6508 +9
==========================================
+ Hits 4491 4502 +11
+ Misses 2008 2006 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
34b397d
to
9c4b8a2
Compare
9c4b8a2
to
5cfed97
Compare
Thanks for the work! |
cb2af4e
to
f45aac4
Compare
Sure haven't. @giovannipizzi could you test the PR, see if it fixes your issue? |
f45aac4
to
55e5867
Compare
Hi @superstar54 for the sake of time, can we approve this one? A quick lookup online suggests that using an anchor tag (via an HTML widget) is standard across browsers and should not trigger a pop-up in Safari (where a button click trigger of JS Worst case, it doesn't work (same situation we're in without this PR) and we pursue another solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @superstar54 for the sake of time, can we approve this one? A quick lookup online suggests that using an anchor tag (via an HTML widget) is standard across browsers and should not trigger a pop-up in Safari (where a button click trigger of JS window.open does).
Sure! Thanks for the work!
This PR introduces a
LinkButton
widget that mimics aipywidgets.Button
via anipywidgets.HTML
wrapper around an anchor tag (<a>
).Resolves #891
Resolves #988