Utilize external resource setup notebook for code management #986
+51
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edan-bainglass
requested review from
danielhollas,
mikibonacci and
superstar54
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 67.60% 67.60% -0.01%
==========================================
Files 112 112
Lines 6582 6588 +6
==========================================
+ Hits 4450 4454 +4
- Misses 2132 2134 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edan-bainglass
force-pushed
the
external-code-setup-notebook
branch
3 times, most recently
from
cdcfb9d to
e294c37
Compare
|
Hi @superstar54. If you're interested, take a look at the last commit. I moved some stuff around to better fit our overall MVC approach. |
edan-bainglass
force-pushed
the
external-code-setup-notebook
branch
2 times, most recently
from
84a056a to
64fbdb4
Compare
|
@yakutovicha can you say more regarding reasons for previously moving from external code setup to in-line widgets? |
edan-bainglass
force-pushed
the
external-code-setup-notebook
branch
11 times, most recently
from
80e2552 to
ca7a4a5
Compare
edan-bainglass
force-pushed
the
external-code-setup-notebook
branch
from
ca7a4a5 to
af90592
Compare
edan-bainglass
force-pushed
the
external-code-setup-notebook
branch
from
af90592 to
873eb24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1011
This PR provides a top level button and a link in step 3 to the new external resource setup notebook in aiidalab-home (aiidalab/aiidalab-home#188). It also removes the code setup widget buttons from the individual code selectors in step 3 (in favor of the external notebook).