Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support treegraph and treemap modules #472

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Support treegraph and treemap modules #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b42c686
Support treegraph and treemap modules
charlesfries Jul 29, 2024
6497ddc
Add demo, fix import order
charlesfries Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ember-highcharts/src/components/high-charts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,19 @@ export default class HighCharts extends Component<HighChartsSignature> {
SolidGauge.default(Highcharts);
}

if (
this.args.chartOptions?.chart?.type === 'treegraph' ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So treegraph and treemap both require Treemap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Treemap
https://www.highcharts.com/docs/chart-and-series-types/treemap

The treemap chart requires the filemodules/treemap.js.

Treegraph
https://www.highcharts.com/docs/chart-and-series-types/treegraph-chart

In order to use this series type, you need to load the modules/treemap.js and modules/treegraph.js modules.

this.args.chartOptions?.chart?.type === 'treemap'
) {
const Treemap = await import('highcharts/modules/treemap');
Treemap.default(Highcharts);
}

if (this.args.chartOptions?.chart?.type === 'treegraph') {
const Treegraph = await import('highcharts/modules/treegraph');
Treegraph.default(Highcharts);
}

if (this.args.chartOptions?.chart?.type === 'waterfall') {
const More = await import('highcharts/highcharts-more');
More.default(Highcharts);
Expand Down
4 changes: 4 additions & 0 deletions test-app/app/components/chart-treegraph.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<HighCharts
@content={{this.chartData}}
@chartOptions={{this.chartOptions}}
/>
28 changes: 28 additions & 0 deletions test-app/app/components/chart-treegraph.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import Component from '@glimmer/component';

export default class Treegraph extends Component {
chartOptions = {
chart: {
type: 'treegraph',
},
title: {
text: 'Organizational Structure',
},
};

chartData = [
{
keys: ['id', 'parent'],
data: [
['Alice'],
['Bill', 'Alice'],
['Carson', 'Bill'],
['Edward', 'Bill'],
['Dwayne', 'Alice'],
],
dataLabels: {
format: '{point.id}',
},
},
];
}
5 changes: 5 additions & 0 deletions test-app/app/templates/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,8 @@
<h3>Scatter chart</h3>
<ChartScatter />
</section>

<section>
<h3>Treegraph chart</h3>
<ChartTreegraph />
</section>