Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support treegraph and treemap modules #472

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

@charlesfries
Copy link
Contributor Author

@RobbieTheWagner is anything I can do to help get this PR and also #481 merged so all chart types are supported?

Copy link
Collaborator

@RobbieTheWagner RobbieTheWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@charlesfries this looks good to me! I assume you have tested and the chart works? We may want to add this chart type to the demo page as well.

@charlesfries
Copy link
Contributor Author

Will add a demo, give me a few minutes

@charlesfries
Copy link
Contributor Author

Added the demo.

@@ -243,6 +243,19 @@ export default class HighCharts extends Component<HighChartsSignature> {
SolidGauge.default(Highcharts);
}

if (
this.args.chartOptions?.chart?.type === 'treegraph' ||
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So treegraph and treemap both require Treemap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Treemap
https://www.highcharts.com/docs/chart-and-series-types/treemap

The treemap chart requires the filemodules/treemap.js.

Treegraph
https://www.highcharts.com/docs/chart-and-series-types/treegraph-chart

In order to use this series type, you need to load the modules/treemap.js and modules/treegraph.js modules.

@RobbieTheWagner RobbieTheWagner merged commit f720f3e into ahmadsoe:master Oct 4, 2024
12 checks passed
@charlesfries charlesfries deleted the treegraph branch October 4, 2024 16:18
@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants