-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support treegraph and treemap modules #472
Conversation
@RobbieTheWagner is anything I can do to help get this PR and also #481 merged so all chart types are supported? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@charlesfries this looks good to me! I assume you have tested and the chart works? We may want to add this chart type to the demo page as well.
Will add a demo, give me a few minutes |
Added the demo. |
@@ -243,6 +243,19 @@ export default class HighCharts extends Component<HighChartsSignature> { | |||
SolidGauge.default(Highcharts); | |||
} | |||
|
|||
if ( | |||
this.args.chartOptions?.chart?.type === 'treegraph' || |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So treegraph and treemap both require Treemap
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes.
Treemap
https://www.highcharts.com/docs/chart-and-series-types/treemap
The treemap chart requires the filemodules/treemap.js.
Treegraph
https://www.highcharts.com/docs/chart-and-series-types/treegraph-chart
In order to use this series type, you need to load the modules/treemap.js and modules/treegraph.js modules.
https://www.highcharts.com/docs/chart-and-series-types/treemap
https://www.highcharts.com/docs/chart-and-series-types/treegraph-chart