Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm Asynchronous initiate_swarm_chat #315

Merged
merged 3 commits into from
Dec 30, 2024
Merged

Swarm Asynchronous initiate_swarm_chat #315

merged 3 commits into from
Dec 30, 2024

Conversation

marklysze
Copy link
Collaborator

@marklysze marklysze commented Dec 30, 2024

Why are these changes needed?

Add a_initiate_swarm_chat for asynchronous swarm chat.

Includes considerable internal refactoring of initiate_swarm_chat into separate functions.

Includes a fix for GroupChat's a_run_chat to handle NoEligibleSpeaker exceptions.

Related issue number

Closes #299

Checks

Signed-off-by: Mark Sze <[email protected]>
Copy link
Collaborator

@yiranwu0 yiranwu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring! Look good to me.

@qingyun-wu qingyun-wu added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit 69166d2 Dec 30, 2024
211 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request swarm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: async version for initiate_swarm_chat
3 participants