-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge SwarmAgent into ConversableAgent #316
Draft
marklysze
wants to merge
16
commits into
main
Choose a base branch
from
swarmagenttoconversable
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sociated functions Signed-off-by: Mark Sze <[email protected]>
Signed-off-by: Mark Sze <[email protected]>
Signed-off-by: Mark Sze <[email protected]>
Signed-off-by: Mark Sze <[email protected]>
Co-authored-by: Chi Wang <[email protected]>
Signed-off-by: Mark Sze <[email protected]>
…e / AfterWork / OnCondition Signed-off-by: Mark Sze <[email protected]>
…into swarmagenttoconversable
Signed-off-by: Mark Sze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
To expand the use of swarms to allow all ConversableAgent-based agents, this merges SwarmAgent into ConversableAgent.
Progress:
agent.register_hand_off
toregister_hand_off(agent
QUESTIONS/NOTES FOR REVIEWER:
my_agent = SwarmAgent(functions=[function_a, function_b])
). These functions were registered for LLM but not for execution (as a separate agent would execute). How should this work on ConversableAgent? Should it be the same or should there be a way to specify LLM and/or Execution for each function? I have left it as the same for now.__str__
on ConversableAgent and the associated internal function (_get_display_name()
) within it can be overwritten on a ConversableAgent instance, which I've done for any agents associated with a swarm. This means that if you do str(my_conversable_agent) you will get the name of the agent rather than the type as a string.MIGRATION INSTRUCTIONS:
Related issue number
#26
Checks