Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup.py > underscores to hyphens fix #179

Merged
merged 5 commits into from
Dec 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/contrib-graph-rag-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
pip install pytest
- name: Install FalkorDB SDK when on linux
run: |
pip install -e .[graph_rag_falkor_db]
pip install -e .[graph-rag-falkor-db]
- name: Set AUTOGEN_USE_DOCKER based on OS
shell: bash
run: |
Expand Down
2 changes: 1 addition & 1 deletion notebook/agentchat_graph_rag_falkordb.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"FalkorDB's GraphRAG-SDK is a dependency for this notebook, which can be installed with ag2 via pip:\n",
"\n",
"```bash\n",
"pip install ag2[graph_rag_falkor_db]\n",
"pip install ag2[graph-rag-falkor-db]\n",
"```\n",
"\n",
"or if you have already installed ag2/autogen/pyautogen\n",
Expand Down
2 changes: 1 addition & 1 deletion notebook/agentchat_swarm_graphrag_trip_planner.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"FalkorDB's GraphRAG-SDK is a dependency for this notebook, which can be installed with ag2 via pip:\n",
"\n",
"```bash\n",
"pip install ag2[graph_rag_falkor_db]\n",
"pip install ag2[graph-rag-falkor-db]\n",
"```\n",
"\n",
"For more information, please refer to the [installation guide](/docs/installation/).\n",
Expand Down
5 changes: 4 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@
# pysqlite3-binary used so it doesn't need to compile pysqlite3
autobuild = ["chromadb", "sentence-transformers", "huggingface-hub", "pysqlite3-binary"]

# NOTE: underscores in pip install, e.g. pip install ag2[graph_rag_falkor_db], will automatically
# convert to hyphens. So, do not include underscores in the name of extras.

extra_require = {
"test": [
"ipykernel",
Expand All @@ -93,7 +96,7 @@
"retrievechat-pgvector": retrieve_chat_pgvector,
"retrievechat-mongodb": [*retrieve_chat, "pymongo>=4.0.0"],
"retrievechat-qdrant": [*retrieve_chat, "qdrant_client", "fastembed>=0.3.1"],
"graph_rag_falkor_db": graph_rag_falkor_db,
"graph-rag-falkor-db": graph_rag_falkor_db,
"autobuild": autobuild,
"captainagent": autobuild + ["pandas"],
"teachable": ["chromadb"],
Expand Down
Loading