Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup.py > underscores to hyphens fix #179

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

marklysze
Copy link
Collaborator

Why are these changes needed?

pip install does not allow underscores in the package extras, so the graph_rag_falkor_db extra is being interpreted as graph-rag-falkor-db and can't be found in the setup.py.

This fixes that by changing it to hyphens so they can install either:
pip install ag2[graph_rag_falkor_db] or pip install ag2[graph-rag-falkor-db]

Related issue number

Discord issue

Checks

Copy link
Collaborator

@AgentGenie AgentGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.
Could you comment with the information right above this section in the file?

Added comment for future editors
Copy link
Collaborator

@AgentGenie AgentGenie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marklysze marklysze added this pull request to the merge queue Dec 11, 2024
@marklysze marklysze removed this pull request from the merge queue due to a manual request Dec 11, 2024
@marklysze marklysze added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit c431880 Dec 11, 2024
210 of 213 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants