Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix errors in python and clean the code #114

Open
wants to merge 4 commits into
base: 11.0
Choose a base branch
from
Open

Fix errors in python and clean the code #114

wants to merge 4 commits into from

Conversation

JuaniFreedoo
Copy link
Contributor

Fix errors for a clean installation, camelcase in class and delete comments

@JuaniFreedoo
Copy link
Contributor Author

Discarded changes in python

@JuaniFreedoo
Copy link
Contributor Author

Camelcase in class and delete spaces in the end of files

@jjscarafia
Copy link
Contributor

Hi! Thanks @FreeDoo2018
I've made a new PR with a a fix of yours and some other improvements in this PR #115

What do you think? You can test it on runbot here http://runbot.adhoc.com.ar/runbot/repo/https-github-com-aeroo-aeroo-reports-25

@jjscarafia jjscarafia mentioned this pull request Jun 25, 2018
Open
@JuaniFreedoo
Copy link
Contributor Author

Thanks @jjscarafia I will perform tests and I will give you my feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuaniFreedoo @jjscarafia