Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration of aeroo to v11 #103

Open
jjscarafia opened this issue Feb 27, 2018 · 13 comments
Open

Migration of aeroo to v11 #103

jjscarafia opened this issue Feb 27, 2018 · 13 comments

Comments

@jjscarafia
Copy link
Contributor

For anyone following this repository, please consider contributing to this campaign to migrate aeroo reports to v11.
Perhaps as a contribution related to how aeroo has already helped or perhaps because you will need it on the future.
Thanks!

@lukebranch
Copy link

great news! I'll definitely contribute to this asap.

@JuaniFreedoo
Copy link
Contributor

Great !!! I will also contribute to the migration

@sraps
Copy link
Contributor

sraps commented Jun 20, 2018

@JuaniAizean Thanks! Every bit helps.

@JuaniFreedoo
Copy link
Contributor

@sraps thanks, I changed my username

@JuaniFreedoo
Copy link
Contributor

Hi @sraps @jjscarafia , I just tried to install the aeroo reports module for v11 and I had to make the following modifications to install it and it works:

1.- Delete parser_state and parser_def in ir_model.py in def _add_manual_models

2.- Change the action in report_view.xml

I have the code in my repository

@CasVissers-360ERP
Copy link

I tested the module, the changes in the XML of @FreeDoo2018 are necessary. The parser_state issue is because parser_state is defined before it is created. Hence the module won't do a clean install.

I get this error though:
File "/odoo/customer/community/report_aeroo/controllers/main.py", line 58, in report_routes
('Content-Length', len(rset[0]))
TypeError: object of type 'bool' has no len()

@CasVissers-360ERP
Copy link

File "/odoo/customer/community/report_aeroo/models/report.py", line 343, in write
parser._build_model(rec.pool, rec.env.cr)
UnboundLocalError: local variable 'parser' referenced before assignment

@JuaniFreedoo
Copy link
Contributor

JuaniFreedoo commented Jun 21, 2018

Thanks @CasVissers My PR is available for revision

@JuaniFreedoo
Copy link
Contributor

I need to review the changes well, I see errors in the installation

@JuaniFreedoo
Copy link
Contributor

JuaniFreedoo commented Jun 25, 2018

@CasVissers @sraps @jjscarafia I have corrected my PR, the changes in python were not necessary

@jjscarafia
Copy link
Contributor Author

Great! I've answered on the PR (#114). Thanks!

@CasVissers-360ERP
Copy link

CasVissers-360ERP commented Jun 25, 2018

Lots of improvements ! :) New feedback in #115

@JuaniFreedoo
Copy link
Contributor

Thanks @jjscarafia @CasVissers I will perform tests and I will give you my feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants