Add smoke test for enabled JEP 493 for Eclipse Temurin builds #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlambert
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
LGTM, ran a 2nd Grinder against a JDK24 build to verify the test fails with JEP 493 disabled (in https://ci.adoptium.net/job/Grinder/11382).
thanks for the @BeforeTest cleanup
|
Latest grinder: https://ci.adoptium.net/job/Grinder/11388/console |
karianna
approved these changes
Nov 16, 2024
|
Hmm, with this merged, but #4039 not, we'd get smoke test failures for Temurin 24 builds. |
|
4039 now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a smoke test for Eclipse Temurin builds which, after #4039, would expect the included
jlinkto have the capability enabled.Grinder with this fix included is here:
https://ci.adoptium.net/job/Grinder/11381/console
Note in particular this output:
and
While at it I've reduced some code duplication which is now done via
@BeforeTestonce.Thoughts?