Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --enable-linkable-runtime for JDK 24+ #4039

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Add --enable-linkable-runtime for JDK 24+ #4039

merged 1 commit into from
Nov 18, 2024

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Nov 14, 2024 •
edited
Loading

For JDK's including JEP 493, enable the build option for producing a jlink that is capable of linking from the run-time image. A build with it no longer contains the jmods folder. Thus, the size savings. See below for some numbers.

Closes #4035

@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 14, 2024 •
edited
Loading

Test JDK 24 pipeline with this is here.

A few numbers for the compressed JDK tarball/zip - according to Jenkins:

Build Before After
Linux x64 (jdk) 205.54 MiB 133.03 MiB
Windows x64 (jdk) 205.00 MiB 133.40 MiB
MacOSX aarch64 (jdk) 199.04 MiB 129.29 MiB
AIX ppc64 (jdk) 185.14 MiB 110.57 MiB

@jerboaa
Add --enable-linkable-runtime for JDK 24+
2e77153 
For JDK's including JEP 493, enable the build option
for producing a jlink that is capable of linking from
the run-time image.

Closes adoptium#4035
@jerboaa jerboaa force-pushed the linkable-runtime-jdk24 branch from 31eb713 to 2e77153 Compare November 14, 2024 14:36
@jerboaa jerboaa marked this pull request as ready for review November 14, 2024 14:38
This was referenced Nov 14, 2024
Closed
Merged
@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 15, 2024

Smoke tests, verifying this is enabled for Temurin builds are in #4040.

@karianna
Copy link
Contributor

I know a bunch of folks use Temurin + OpenJFX as a combination. IIRC Gluon does publish jmods so I think we should be good there but it would be good to make a big push to get folks to test this.

@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 18, 2024

I know a bunch of folks use Temurin + OpenJFX as a combination.

OK. It's not clear how this change affects that though. Could you clarify?

@gdams
Copy link
Member

gdams commented Nov 18, 2024

We'll need to raise a PR to ci-jenkins-pipelines to prevent building an exploded image and signing the jmods:

https://github.com/adoptium/ci-jenkins-pipelines/blob/5bd79eb1d95a033c4ee364a8f9fcc270ad653178/pipelines/build/common/openjdk_build_pipeline.groovy#L1878-L1913

@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 18, 2024

We'll need to raise a PR to ci-jenkins-pipelines to prevent building an exploded image and signing the jmods:

https://github.com/adoptium/ci-jenkins-pipelines/blob/5bd79eb1d95a033c4ee364a8f9fcc270ad653178/pipelines/build/common/openjdk_build_pipeline.groovy#L1878-L1913

OK.

@jerboaa jerboaa merged commit aa3791f into adoptium:master Nov 18, 2024
26 checks passed
@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 18, 2024

We'll need to raise a PR to ci-jenkins-pipelines to prevent building an exploded image and signing the jmods:

https://github.com/adoptium/ci-jenkins-pipelines/blob/5bd79eb1d95a033c4ee364a8f9fcc270ad653178/pipelines/build/common/openjdk_build_pipeline.groovy#L1878-L1913

adoptium/ci-jenkins-pipelines#1145 should do that I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdams gdams gdams approved these changes

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JDK 24] Enable JEP 493 in Temurin 24 builds
4 participants
@jerboaa @karianna @gdams @sxa