Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add perl-IPC-Cmd to Redhat/CentOS installs for OpenSSL v3 compile #2855

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

jdekonin
Copy link
Contributor

Signed-off-by: Joe deKoning [email protected]

* compiling openssl v3 within container or system requires this package
* see eclipse-openj9/openj9#14930

Signed-off-by: Joe deKoning <[email protected]>
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdekonin I'm ok with this going in, but is an equivalent requird for non-RH/CentOS systems if people want to build on, say, Ubuntu?

@jdekonin
Copy link
Contributor Author

jdekonin commented Jan 5, 2023

I compiled openssl v3 on a Ubuntu 20 s390x system without any added package requirements. But I think it will depend on the o/s release & level. Compilation requirements are not spelled out at https://github.com/openssl/openssl.git but if users encounter problem with compiling openssl I think the best direction would be to send them to that projects, although there would be nothing wrong with asking the questions in slack either. :)

@sxa
Copy link
Member

sxa commented Jan 6, 2023

I compiled openssl v3 on a Ubuntu 20 s390x system without any added package requirements. But I think it will depend on the o/s release & level. Compilation requirements are not spelled out at https://github.com/openssl/openssl.git but if users encounter problem with compiling openssl I think the best direction would be to send them to that projects, although there would be nothing wrong with asking the questions in slack either. :)

OK thanks for confirming. If you're reasonably confident it's covered I'm fine with that and will merge.

@sxa sxa merged commit cb68afd into adoptium:master Jan 6, 2023
@pshipton
Copy link
Contributor

@sxa do you know when can we expect the docker images to be updated with this change? Looking at https://hub.docker.com/r/adoptopenjdk/centos7_build_image/tags the last update atm was Jan 10 but it doesn't contain this fix (or the fix isn't correct). The build still results in:

11:55:20  Can't locate IPC/Cmd.pm in @INC (@INC contains: /home/jenkins/workspace/Build_JDK8_aarch64_linux_Personal/openssl/util/perl /usr/local/lib64/perl5 /usr/local/share/perl5 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5 . /home/jenkins/workspace/Build_JDK8_aarch64_linux_Personal/openssl/external/perl/Text-Template-1.56/lib) at /home/jenkins/workspace/Build_JDK8_aarch64_linux_Personal/openssl/util/perl/OpenSSL/config.pm line 19.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

pshipton added a commit to pshipton/infrastructure that referenced this pull request Apr 3, 2023
* compiling openssl v3 within container or system requires this package
* see eclipse-openj9/openj9#14930

These were added in adoptium#2855
but in the wrong place.

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/infrastructure that referenced this pull request Apr 3, 2023
* compiling openssl v3 within container or system requires this package
* see eclipse-openj9/openj9#14930

These were added in adoptium#2855
but in the wrong place.

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/infrastructure that referenced this pull request Apr 3, 2023
compile

* compiling openssl v3 within container or system requires this package
* see eclipse-openj9/openj9#14930

These were added in adoptium#2855
but in the wrong place.

Signed-off-by: Peter Shipton <[email protected]>
pshipton added a commit to pshipton/infrastructure that referenced this pull request Apr 3, 2023
compile

* compiling openssl v3 within container or system requires this package
* see eclipse-openj9/openj9#14930

These were added in adoptium#2855
but in the wrong place. perl-IPC-Cmd is required for all platforms.

Signed-off-by: Peter Shipton <[email protected]>
sxa pushed a commit that referenced this pull request Apr 4, 2023
)

compile

* compiling openssl v3 within container or system requires this package
* see eclipse-openj9/openj9#14930

These were added in #2855
but in the wrong place. perl-IPC-Cmd is required for all platforms.

Signed-off-by: Peter Shipton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants