-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perl-IPC-Cmd to Redhat/CentOS installs for OpenSSL v3 compile #2855
Conversation
* compiling openssl v3 within container or system requires this package * see eclipse-openj9/openj9#14930 Signed-off-by: Joe deKoning <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdekonin I'm ok with this going in, but is an equivalent requird for non-RH/CentOS systems if people want to build on, say, Ubuntu?
I compiled openssl v3 on a Ubuntu 20 s390x system without any added package requirements. But I think it will depend on the o/s release & level. Compilation requirements are not spelled out at https://github.com/openssl/openssl.git but if users encounter problem with compiling openssl I think the best direction would be to send them to that projects, although there would be nothing wrong with asking the questions in slack either. :) |
OK thanks for confirming. If you're reasonably confident it's covered I'm fine with that and will merge. |
@sxa do you know when can we expect the docker images to be updated with this change? Looking at https://hub.docker.com/r/adoptopenjdk/centos7_build_image/tags the last update atm was Jan 10 but it doesn't contain this fix (or the fix isn't correct). The build still results in:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge
and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw
.
* compiling openssl v3 within container or system requires this package * see eclipse-openj9/openj9#14930 These were added in adoptium#2855 but in the wrong place. Signed-off-by: Peter Shipton <[email protected]>
* compiling openssl v3 within container or system requires this package * see eclipse-openj9/openj9#14930 These were added in adoptium#2855 but in the wrong place. Signed-off-by: Peter Shipton <[email protected]>
compile * compiling openssl v3 within container or system requires this package * see eclipse-openj9/openj9#14930 These were added in adoptium#2855 but in the wrong place. Signed-off-by: Peter Shipton <[email protected]>
compile * compiling openssl v3 within container or system requires this package * see eclipse-openj9/openj9#14930 These were added in adoptium#2855 but in the wrong place. perl-IPC-Cmd is required for all platforms. Signed-off-by: Peter Shipton <[email protected]>
) compile * compiling openssl v3 within container or system requires this package * see eclipse-openj9/openj9#14930 These were added in #2855 but in the wrong place. perl-IPC-Cmd is required for all platforms. Signed-off-by: Peter Shipton <[email protected]>
Signed-off-by: Joe deKoning [email protected]