-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unixPB: Add perl-IPC-Cmd to Redhat/CentOS installs for OpenSSL v3 #3014
Conversation
compile * compiling openssl v3 within container or system requires this package * see eclipse-openj9/openj9#14930 These were added in adoptium#2855 but in the wrong place. perl-IPC-Cmd is required for all platforms. Signed-off-by: Peter Shipton <[email protected]>
@sxa can you pls help with the review and testing on this. |
VPC run on JDK17/J9: https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1659/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if it passes testing
Tests failed due to adoptium/temurin-build#3252 (Freemarker download failing) but since that has now been removed from the default options in OpenJ9's build process we should likely do the same ... |
Is that going to block merging this? I can look at removing freemarker in another PR if that helps, searching for references to freemarker and deleting it all. |
Stay tuned :-) I'm running another test with a branch that should disable it at https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1660/ |
Interesting - got a memory exhausted error on Debian 10 and it was unable to find nasm when configuring the build on Ubuntu 20.04, but CentOS 8 was happy so hopefully the others will be ok too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - CentOS 6 and 7 worked ok
Related to adoptium/infrastructure#3014 adoptium/infrastructure#3083 Signed-off-by: Peter Shipton <[email protected]>
These were added in #2855 but in the wrong place. perl-IPC-Cmd is required for all platforms.
Checklist