Only do exploded build for win/mac for specific builds #1145
Conversation
Only do exploded build, required for JMOD artifact signing, when JDK version N such that 10 < N <= 23.
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
|
run tests quick 24 |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
Hmm, looks like the failure is this? Not sure what to make of it, though. |
|
run tests quick 23 |
PR TESTER RESULT ❎ Some pipelines failed or the job was aborted! ❎ |
|
Looks like a similar failure: @gdams Do you know? Is the PR tester supposed to handle JDK 23/24 pipeline testing? |
|
Going by adoptium/temurin-build#4057 this might need some work. |
| buildConfig.JAVA_TO_BUILD == 'jdk17u' || | ||
| buildConfig.JAVA_TO_BUILD == 'jdk21u' || | ||
| buildConfig.JAVA_TO_BUILD == 'jdk23u') | ||
| && enableSigner) { |
There was a problem hiding this comment.
We need this dual pass build with signing to resolve: adoptium/temurin-build#4057 (comment)
and adoptium/temurin-build#3997
I shall be working on a fix for these
There was a problem hiding this comment.
Shall I close this PR?
Only do exploded build, required for JMOD artifact signing, when JDK version
Nsuch that10 < N <= 23.