Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hamcrest-core.jar and bcprov-jdk18on.jar in getDependencies #493

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Jan 31, 2024

@llxia llxia marked this pull request as ready for review February 1, 2024 15:44
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JasonFengJ9 JasonFengJ9 merged commit 3509137 into adoptium:master Feb 1, 2024
3 checks passed
pushkarnk added a commit to pushkarnk/TKG that referenced this pull request Feb 5, 2024
adoptium#493 added the JDK_VENDOR
property to the compile command. This value is picked up from
the "java.vendor" property of the test JDK in TEST_JDK_HOME. If
the "java.vendor" value has a whitespace, it breaks the new compile
command. Hence, the commit proposes using "" around $(JDK_VENDOR) in
COMPILE_CMD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants