Support vendor names with spaces in compile.mk

[pushkarnk]

#493 added the JDK_VENDOR property to the compile command. This value is picked up from the "java.vendor" property of the test JDK in TEST_JDK_HOME. If the "java.vendor" value has a whitespace, it breaks the new compile command. Hence, the commit proposes using "" around $(JDK_VENDOR) in COMPILE_CMD.

The new TKG caused failure on Ubuntu because the Ubuntu JDK builds have "java.vendor" set to "Private Build".

[pushkarnk]

@llxia Can you review this please?

[llxia]

vendor is a key value that we will use to enable/disable tests. Each vendor would have its own value

TKG/src/org/openj9/envInfo/JavaInfo.java

Lines 167 to 198 in 6ab3f8f

	public String getJDKVendor() {
	String vendor = System.getProperty("java.vendor");
	System.out.println("System.getProperty('java.vendor')=" + vendor + "\n");
	String vendorLC = vendor.toLowerCase();
	if (vendorLC.contains("adoptopenjdk")) {
	return "adoptopenjdk";
	} else if (vendorLC.contains("eclipse")) {
	return "eclipse";
	} else if (vendorLC.contains("ibm") || vendorLC.contains("international business machines corporation")) {
	return "ibm";
	} else if (vendorLC.contains("alibaba")) {
	return "alibaba";
	} else if (vendorLC.contains("amazon")) {
	return "amazon";
	} else if (vendorLC.contains("azul")) {
	return "azul";
	} else if (vendorLC.contains("sap")) {
	return "sap";
	} else if (vendorLC.contains("bellsoft")) {
	return "bellsoft";
	} else if (vendorLC.contains("oracle")) {
	return "oracle";
	} else if (vendorLC.contains("red hat")) {
	return "redhat";
	} else if (vendorLC.contains("microsoft")) {
	return "microsoft";
	} else if (vendorLC.contains("loongson")) {
	return "loongson";
	} else {
	System.out.println("Warning: cannot determine vendor, use System.getProperty('java.vendor')=" + vendor + " directly.\n");
	return vendor;
	}

What is the full output of your "java.vendor"? Just "Private Build" or it contains vendor name (i.e., Canonical Private Build)?

By setting "java.vendor" to just "Private Build" (a generic name), it would be hard to enable/disable tests based on the specific vendor build (i.e., Canonical build) in the future.

Ideally, the correct way is to add "java.vendor" support above JavaInfo.java:

else if (vendorLC.contains("canonical")) { 
            return "canonical"; 
}

[pushkarnk]

Got your point @llxia. Thank you.