-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert addon to TypeScript & add glint #581
Merged
NullVoxPopuli
merged 35 commits into
adopted-ember-addons:master
from
mkszepp:convert-to-ts
Sep 21, 2024
Merged
Changes from 5 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
a4a0ed2
Convert addon to TS
mkszepp a0acbec
Convert eslint.. for TS support & update linters
mkszepp 8ba0971
Revert comment inside drag.ts
mkszepp bdb02d9
Fix missing addon main file
mkszepp 11b78ab
Fix missing addon main file
mkszepp c6e4a8d
Regenerate lock file
mkszepp 4673459
Add .npmrc & add missing dependencies inside addon
mkszepp 7c41fba
Update some packages to fix tests
mkszepp b85c399
Import hbs from ember-cli-htmlbars
mkszepp 4f80164
More modernizing test app
mkszepp 2e42bda
Drop more outdated packages from test / docs app
mkszepp 3f8abb7
Sync `@embroider/test-setup` between test-app & docs
mkszepp 1d8b3c8
Remove resolver.js file & add dependency injection also to docs
mkszepp 9fa92ea
Readd lock file
mkszepp 0c2b307
Fix test
mkszepp 43c1bbb
Remove dependency injection in docs (isn't working)
mkszepp 4ec6bf1
Fix lock file
mkszepp 303a12c
Merge branch 'adopted-ember-addons:master' into convert-to-ts
mkszepp f9557cc
Update `@embroider/test-setup` to latest
mkszepp d370c9e
Disable prototype extension
mkszepp 4df7737
Fix for ember 6
mkszepp 6107c56
Fix docs for ember 6
mkszepp a884e45
Add ember-lts-v5.8 in ember-try & add try mode for test-helper v2 & v…
mkszepp fae3077
Replace ember-modifier-4 with ember-modifier-3 (test-app has now v4 b…
mkszepp 281ed64
Merge branch 'master' into convert-to-ts
mkszepp a4248d5
Fix lock file
mkszepp 308528e
Revert comment change in reorder test-helper
mkszepp 0e380c5
Fix incorrect merging
mkszepp fbe6b78
Fix incorrect merge
mkszepp b895588
Remove new line
mkszepp 5857ad2
Replace npm-run-all with concurrently
mkszepp 84f0053
Readd `eslint-plugin-import` (was removed while merge)
mkszepp 4a2dca2
Fix lint & readd ember-template-lint (dropped while merge)
mkszepp 053b025
Rename `VisualClass` interface to `HandleVisualClass` and make it pub…
mkszepp 2bee092
Improve error handing and fix interface name in template-registry
mkszepp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
|
|
||
| # compiled output | ||
| /dist/ | ||
| /declarations/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| 'use strict'; | ||
|
|
||
| module.exports = { | ||
| root: true, | ||
| // Only use overrides | ||
| // https://github.com/ember-cli/eslint-plugin-ember?tab=readme-ov-file#gtsgjs | ||
| overrides: [ | ||
| { | ||
| files: ['**/*.js', '**/*.ts'], | ||
| env: { browser: true }, | ||
| parser: '@typescript-eslint/parser', | ||
| parserOptions: { | ||
| ecmaVersion: 'latest', | ||
| }, | ||
| plugins: ['ember', 'import'], | ||
| extends: ['eslint:recommended', 'plugin:ember/recommended', 'plugin:prettier/recommended'], | ||
| rules: { | ||
| // require relative imports use full extensions | ||
| 'import/extensions': ['error', 'always', { ignorePackages: true }], | ||
| 'ember/no-runloop': 0, | ||
| // Add any custom rules here | ||
| }, | ||
| }, | ||
| // ts files | ||
| { | ||
| files: ['**/*.ts'], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:ember/recommended', | ||
| 'plugin:@typescript-eslint/eslint-recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:prettier/recommended', | ||
| ], | ||
| rules: { | ||
| // require relative imports use full extensions | ||
| 'import/extensions': ['error', 'always', { ignorePackages: true }], | ||
| 'ember/no-runloop': 0, | ||
| // Add any custom rules here | ||
| }, | ||
| }, | ||
| { | ||
| files: ['**/*.gts'], | ||
| parser: 'ember-eslint-parser', | ||
| plugins: ['ember', 'import'], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:@typescript-eslint/eslint-recommended', | ||
| 'plugin:@typescript-eslint/recommended', | ||
| 'plugin:ember/recommended', | ||
| 'plugin:ember/recommended-gts', | ||
| 'plugin:prettier/recommended', | ||
| ], | ||
| rules: { | ||
| // require relative imports use full extensions | ||
| 'import/extensions': ['error', 'always', { ignorePackages: true }], | ||
| // Add any custom rules here | ||
| }, | ||
| }, | ||
| { | ||
| files: ['**/*.gjs'], | ||
| parser: 'ember-eslint-parser', | ||
| plugins: ['ember', 'import'], | ||
| extends: [ | ||
| 'eslint:recommended', | ||
| 'plugin:ember/recommended', | ||
| 'plugin:ember/recommended-gjs', | ||
| 'plugin:prettier/recommended', | ||
| ], | ||
| rules: { | ||
| // require relative imports use full extensions | ||
| 'import/extensions': ['error', 'always', { ignorePackages: true }], | ||
| // Add any custom rules here | ||
| }, | ||
| }, | ||
| // node files | ||
| { | ||
| files: ['./.eslintrc.cjs', './.prettierrc.cjs', './.template-lintrc.cjs', './addon-main.cjs'], | ||
| parserOptions: { | ||
| sourceType: 'script', | ||
| }, | ||
| env: { | ||
| browser: false, | ||
| node: true, | ||
| }, | ||
| plugins: ['n'], | ||
| extends: ['eslint:recommended', 'plugin:n/recommended', 'plugin:prettier/recommended'], | ||
| }, | ||
| ], | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ LICENSE.md | |
|
|
||
| # compiled output | ||
| /dist/ | ||
| /declarations/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |
|
|
||
| # compiled output | ||
| /dist/ | ||
| /declarations/ | ||
| /tmp/ | ||
|
|
||
| # dependencies | ||
|
|
||
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,4 @@ | ||
| 'use strict'; | ||
|
|
||
| const { addonV1Shim } = require('@embroider/addon-shim'); | ||
| module.exports = addonV1Shim(__dirname); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this dependencies were always missed 😁, but used inside addon