Convert addon to TypeScript & add glint #581
Conversation
✅ Deploy Preview for ember-sortable canceled.
|
| if (!scrollParent || scrollParent === document.body) { | ||
| scrollParent = document; | ||
| } | ||
| return position === 'fixed' || scrollParent; |
There was a problem hiding this comment.
while TS converting removed position === 'fixed' because it makes no sense... the return must be a HTMLElement or Document otherwise code is not correctly in scroll-container.ts because he needs always a dom element https://github.com/adopted-ember-addons/ember-sortable/pull/581/files#diff-49b1162a2852f7a45dc24d5027bc3ea12f95d37caef8c2b020f7709803bb01a6R24
| const sortedItems = this.sortedItems; | ||
| const itemElement = sortedItems[moves[0].fromIndex].element; |
There was a problem hiding this comment.
this code was never correct... moves is a array of number array
| instance.announcer.parentNode.removeChild(instance.announcer); | ||
| } | ||
| instance.removeEventListener(); | ||
| instance.sortableService.deregisterGroup(instance.groupName, instance); |
There was a problem hiding this comment.
deregisterGroup has no 2nd parameter, so i have removed in TS
| "@embroider/macros": "^1.16.6", | ||
| "@glimmer/env": "^0.1.7", | ||
| "rsvp": "^4.8.5" |
There was a problem hiding this comment.
this dependencies were always missed 😁, but used inside addon
…4 (app has atm v3)
|
ci is now greeen 🎉... For ember-canary ( ember 6) there were necessary to make some deprecation cleanup (template location and disable prototype extension)... this test fails atm also on master. |
…lic (possible helpful for consumer apps)
NullVoxPopuli
merged commit 1572469
into
adopted-ember-addons:master
This PR converts the addon to TS and adds glint support