Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Body text not updating on revisit with linked confidence sliders (fixes #101) #104

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Fix: Body text not updating on revisit with linked confidence sliders (fixes #101) #104

merged 4 commits into from
Nov 2, 2023

Conversation

joe-allen-89
Copy link
Contributor

#101

Fix

@joe-allen-89 joe-allen-89 self-assigned this Oct 19, 2023
@joe-allen-89 joe-allen-89 linked an issue Oct 19, 2023 that may be closed by this pull request
Disabled Body text still displayed #101
Closed
oliverfoster
oliverfoster approved these changes Oct 26, 2023
View reviewed changes
js/ConfidenceSliderModel.js Outdated Show resolved Hide resolved
js/ConfidenceSliderModel.js Outdated Show resolved Hide resolved
joe-allen-89 and others added 2 commits October 27, 2023 14:04
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected. Testing on Mac Safari, Chrome and FF

@kirsty-hames kirsty-hames merged commit 94bfa9f into master Nov 2, 2023
@kirsty-hames kirsty-hames deleted the issue/101 branch November 2, 2023 10:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023

🎉 This PR is included in version 5.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabled Body text still displayed
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool