Fix: Body text not updating on revisit with linked confidence sliders (…

…fixes #101)
adaptlearning · Nov 2, 2023 · 94bfa9f · 94bfa9f
2 parents 8a2eed4 + 7674f32
commit 94bfa9f
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 23 deletions.
diff --git a/js/ConfidenceSliderModel.js b/js/ConfidenceSliderModel.js
@@ -9,7 +9,11 @@ export default class ConfidenceSliderModel extends SliderModel {
     super.init();
     if (!this.get('_linkedToId')) return;
     this.set('originalBody', this.get('body'));
-    this._setupLinkedModel();
+    this.setupEventListeners();
+  }
+
+  setupEventListeners() {
+    this.listenToOnce(Adapt, 'adapt:initialize', this._setupLinkedModel);
   }
 
   /* override */
@@ -111,6 +115,20 @@ export default class ConfidenceSliderModel extends SliderModel {
     return feedbackString;
   }
 
+  updateFromLinkedModel() {
+    const isSubmitted = this.linkedModel.get('_isSubmitted');
+    this.set('body', isSubmitted ? this.get('originalBody') : this.get('disabledBody'));
+    this.set('_isEnabled', isSubmitted);
+    if (isSubmitted) {
+      this.set('_linkedModelSelectedIndex', this.linkedModel.get('_selectedItem').index);
+    }
+    this.checkCanSubmit();
+  }
+
+  _listenToLinkedModel() {
+    this.listenTo(this.linkedModel, 'change:_isSubmitted', this.updateFromLinkedModel);
+  }
+
   _setupLinkedModel() {
     this.linkedModel = Adapt.components.findWhere({ _id: this.get('_linkedToId') });
     if (!this.linkedModel) {
@@ -129,6 +147,8 @@ export default class ConfidenceSliderModel extends SliderModel {
       _scaleStart: this.linkedModel.get('_scaleStart'),
       _scaleEnd: this.linkedModel.get('_scaleEnd')
     });
+    this._listenToLinkedModel();
+    this.updateFromLinkedModel();
     if (this.get('_attempts') < 0) this.linkedModel.set('_attempts', 1);
   }
 

diff --git a/js/ConfidenceSliderView.js b/js/ConfidenceSliderView.js
@@ -17,22 +17,7 @@ class ConfidenceSliderView extends SliderView {
     super.setupQuestion();
   }
 
-  _listenToLinkedModel() {
-    this.listenTo(this.model.linkedModel, {
-      'change:_isSubmitted': this.onLinkedSubmittedChanged
-    });
-  }
-
   onQuestionRendered() {
-    if (this.model.linkedModel) {
-      this._listenToLinkedModel();
-      if (!this.model.linkedModel.get('_isSubmitted')) {
-        this.model.set('_isEnabled', false);
-        this.model.set('body', this.model.get('disabledBody'));
-      } else {
-        this.model.set('_linkedModelSelectedIndex', this.model.linkedModel.get('_selectedItem').index);
-      }
-    }
     if (!(this.model.get('_isSubmitted') && this.model.has('_userAnswer'))) return;
     this.model.set({
       feedbackTitle: this.model.get('title'),
@@ -56,13 +41,6 @@ class ConfidenceSliderView extends SliderView {
     super.onNumberSelected(value);
   }
 
-  onLinkedSubmittedChanged(linkedModel) {
-    this.model.set('body', this.model.get('originalBody'));
-    this.model.set('_isEnabled', (linkedModel.get('_isSubmitted') === true));
-    this.model.set('_linkedModelSelectedIndex', linkedModel.get('_selectedItem').index);
-    this.model.checkCanSubmit();
-  }
-
 }
 
 ConfidenceSliderView.template = 'confidenceSlider.jsx';