-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-2409] Enable local dataset usage with Indra #2573
Merged
Merged
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
fa73053
first changes
adolkhan 3008160
few more changes
adolkhan c8796b3
added tests
adolkhan 518ea2e
Merge branch 'main' into vectorstore_indra_local
adolkhan 71dab4e
Changes
adolkhan 0616fdf
WIP
adolkhan 7325267
Changes + tests
adolkhan 3fb8266
Merge branch 'main' into vectorstore_indra_local
adolkhan ae8072f
code clean up
adolkhan 2e70b95
Changed feature_report_path
adolkhan 6a966e4
Added path
adolkhan 9becdbc
tests fix
adolkhan f780e17
Code smell fix
adolkhan 29ceb26
Fix CLI test
adolkhan ce88665
remove duplicate
adolkhan 68885b5
upd
adolkhan 2095402
test fix
adolkhan 6014d4b
removing username from params
adolkhan cace8ab
Changes
adolkhan 06f455f
Sonar fix
adolkhan 181d977
Tests fix
adolkhan 6155979
darglint fix
adolkhan 84700a6
Extended VectorStore functionality
adolkhan 84d12cc
marked test as slow
adolkhan e9850dd
Merge branch 'main' into vectorstore_indra_local
adolkhan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4684,3 +4684,6 @@ def _temp_write_access(self): | |
|
||
def _get_storage_repository(self) -> Optional[str]: | ||
return getattr(self.base_storage, "repository", None) | ||
|
||
def get_user_name(self) -> Optional[str]: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this used? |
||
return getattr(self.base_storage, "user_name", None) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have
username
parameter when it is inferred from credentials?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
token
counts as creds?