-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AL-2409] Enable local dataset usage with Indra #2573
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2573 +/- ##
==========================================
- Coverage 83.93% 79.96% -3.97%
==========================================
Files 224 224
Lines 24504 24643 +139
==========================================
- Hits 20567 19707 -860
- Misses 3937 4936 +999
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, will also need to add more coverage
deeplake/api/dataset.py
Outdated
@@ -361,6 +363,7 @@ def empty( | |||
lock_enabled: Optional[bool] = True, | |||
lock_timeout: Optional[int] = 0, | |||
verbose: bool = True, | |||
username: str = "public", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have username
parameter when it is inferred from credentials?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does token
counts as creds?
deeplake/core/dataset/dataset.py
Outdated
@@ -4684,3 +4684,6 @@ def _temp_write_access(self): | |||
|
|||
def _get_storage_repository(self) -> Optional[str]: | |||
return getattr(self.base_storage, "repository", None) | |||
|
|||
def get_user_name(self) -> Optional[str]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used?
Kudos, SonarCloud Quality Gate passed! |
🚀 🚀 Pull Request
Impact
Description
In this PR I am doing 2 main changes:
compute_engine
, while if you log out automatically change to pythonSome Benchmarking on dataset creation using VecotrStore:
Things to be aware of
May be its worth testing thoroughly bugout username reporting with different configurations
Things to worry about
Additional Context