queue based stream #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,10 +195,11 @@ - (void)createHTTPRequest | |||
| (__bridge CFStringRef)headerWSHostName, | |||
| (__bridge CFStringRef)[NSString stringWithFormat:@"%@:%@",self.url.host,port]); | |||
|
|
|||
| for(NSString *key in self.headers) { | |||
| NSDictionary *heads = [self.headers copy]; | |||
There was a problem hiding this comment.
Since this method was moved unto the client thread, the copy is a bit pedantic.
I had suggested adding copy to the addHeader: method itself, which would make self.headers immutable and totally safe under any situation.
This was referenced Apr 14, 2015
Conflicts: JFRWebSocket.m
Especially important for Autobahn tests, but also useful for certain client situations.
Conflicts: JFRWebSocket.m
[AK] For #25 – Additional cleanup
|
@adamkaplan is any of this still valuable that can be merged in master? |
|
Yeah..... lot of great stuff in there actually. But it still fails the Autobahn high-performance tests. I haven't had time to fix it and probably won't for quite a while. It hurts to leave this incomplete for so long 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the concerns in #15 and #18. I believe it might fix the issues in #13. This will supersede the feature/thread #16 PR.