shared singleton thread #16
Conversation
| static JFRThread *manager = nil; | ||
| static dispatch_once_t onceToken; | ||
| dispatch_once(&onceToken, ^{ | ||
| manager = [[[self class] alloc] init]; |
There was a problem hiding this comment.
In a class method, self is already a Class, so this is redundant:
manager = [[[self class] alloc] init];
Better as:
manager = [[self alloc] init];
|
Note: should not be merged if #25 is accepted |
|
Any update on whether this or #25 will be accepted? |
|
@jtreanor we ran into some snags with some reference problems using the queue based API in #25 (Since that seems to be the better way to go) and haven't gotten a chance since to look at it again. It is definitely something we would like to finish, as if it works well it would be a win for Starscream as well. |
|
Cool, thanks @acmacalister We are considering moving back to jetfire from SocketRocket (we switched after encountering #9 and #13). It looks like Jetfire has gotten even better since the 😄 |
|
@jtreanor cool. If you end up switching back, let us know if you run into anything. 😄 |
This for the enhancement for #15. Feedback appreciated.