Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACT-122] Remove view component support / ably-ui gem #304

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

dpiatek
Copy link
Contributor

@dpiatek dpiatek commented Dec 13, 2023

Jira Ticket Link / Motivation

https://ably.atlassian.net/browse/ACT-122

This is the next step after https://github.com/ably/website/pull/5800. We remove all VW components, leaving the preview app, deployment and other tooling intact.

With these changes in, the preview app (and possibly also our cypress setup) could get removed too, and Storybook added (which I've started in #302).

Note there are 2 components which don't have JSX component and yet are still here:

  • CompanyAutocomplete
  • FeatureFooter

They provide CSS/JS that is still used in the website repo.

EDIT (jamiehenson - 11/3/24):
CompanyAutocomplete and FeatureFooter assets now removed from ably-ui, and moved to website via this PR.

Summary of changes

See commits for details.

I've taken some shortcuts, assuming the preview app is on it's way out:

  • some tests are flaky, notable ones around hover, which Cypress is notoriously bad add. I've just commented these out. I think tests should be re-written in the framework Storbybook provides
  • I've copied some images that were previously fetched from the gem into the preview app. This is just for showcasing purposes so should not matter.

How do you manually test this?

Head over to the review app and click around!

Reviewer Tasks (optional)

Merge/Deploy Checklist

  • Written automated tests for implemented features/fixed bugs
  • Rebased and squashed commits
  • Commits have clear descriptions of their changes
  • Checked for any performance regressions

Frontend Checklist

  • No frontend changes in this PR
  • Added before/after screenshots for changes
  • Tested on different platforms/browsers with Browserstack
  • Compared with the initial design / our brand guidelines
  • Checked the code for accessibility issues (VoiceOver User Guide)?

@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-1fxhnx December 13, 2023 17:57 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from aff6f9b to d0002c7 Compare December 14, 2023 10:31
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-wnt5wt December 14, 2023 10:31 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from d0002c7 to 31bc8d9 Compare December 14, 2023 10:42
@ably-ci ably-ci had a problem deploying to ably-ui-remove-view-com-32agqb December 14, 2023 10:42 Failure
@dpiatek dpiatek temporarily deployed to ably-ui-remove-view-com-32agqb December 14, 2023 10:43 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from 1bbda12 to 49a8f15 Compare December 14, 2023 10:44
@ably-ci ably-ci had a problem deploying to ably-ui-remove-view-com-k1ctlz December 14, 2023 10:45 Failure
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-8k5het December 14, 2023 10:45 Inactive
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-opdlkw December 14, 2023 10:51 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from 05b52e9 to 3fa142f Compare December 14, 2023 10:53
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-unosjf December 14, 2023 10:53 Inactive
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-u4cedt December 14, 2023 11:03 Inactive
@dpiatek dpiatek changed the title Remove view component support [ACT-122] Remove view component support / ably-ui gem Dec 14, 2023
@dpiatek dpiatek force-pushed the remove-view-component-support branch from 61f0be2 to a9ae563 Compare December 14, 2023 11:55
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-vx7qkm December 14, 2023 11:56 Inactive
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-83puod December 14, 2023 12:09 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from b6fd9a3 to d3019ca Compare December 14, 2023 12:23
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-womfjo December 14, 2023 12:23 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from d3019ca to 8a8b050 Compare December 14, 2023 12:31
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-lywpze December 14, 2023 12:31 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from 8a8b050 to d5653c5 Compare December 14, 2023 12:37
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-zk6gtv December 14, 2023 12:37 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from d5653c5 to 2d8a4f0 Compare December 14, 2023 13:08
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-w7h1xl December 14, 2023 13:09 Inactive
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-6yf17k December 14, 2023 13:15 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from ff798da to e735d0c Compare December 14, 2023 13:28
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-9xamii December 14, 2023 13:28 Inactive
@dpiatek dpiatek force-pushed the remove-view-component-support branch from e735d0c to 6c7eede Compare December 14, 2023 13:37
@ably-ci ably-ci temporarily deployed to ably-ui-remove-view-com-r8guzd December 14, 2023 13:37 Inactive
@dpiatek dpiatek marked this pull request as ready for review December 14, 2023 13:41
@jamiehenson jamiehenson force-pushed the remove-view-component-support branch from 6c7eede to fe55d05 Compare March 11, 2024 15:45
@jamiehenson jamiehenson requested review from kennethkalmer and denissellu and removed request for kennethkalmer and denissellu March 11, 2024 16:03
@jamiehenson
Copy link
Member

@kennethkalmer @denissellu I've migrated the two components Dominik mentioned in the PR description away into website vis this PR so it's ready for a re-review - I've checked over the rest of the PR and it seems sane.

Copy link
Member

@kennethkalmer kennethkalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice to see this step change in the project!

@jamiehenson jamiehenson merged commit eff60ae into main Mar 13, 2024
3 checks passed
@jamiehenson jamiehenson deleted the remove-view-component-support branch March 13, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants