-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACT-122] Remove view component support / ably-ui gem #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 10:31
aff6f9b
to
d0002c7
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 10:42
d0002c7
to
31bc8d9
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 10:44
1bbda12
to
49a8f15
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 10:53
05b52e9
to
3fa142f
Compare
dpiatek
changed the title
Remove view component support
[ACT-122] Remove view component support / ably-ui gem
Dec 14, 2023
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 11:55
61f0be2
to
a9ae563
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 12:23
b6fd9a3
to
d3019ca
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 12:31
d3019ca
to
8a8b050
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 12:37
8a8b050
to
d5653c5
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 13:08
d5653c5
to
2d8a4f0
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 13:28
ff798da
to
e735d0c
Compare
dpiatek
force-pushed
the
remove-view-component-support
branch
from
December 14, 2023 13:37
e735d0c
to
6c7eede
Compare
It's no longer required to run bundler/check gems in root
In the future, tests should be migrated to Storyblok - hence I don't think there is much point in spending a lot of time here fixing them.
jamiehenson
force-pushed
the
remove-view-component-support
branch
from
March 11, 2024 15:45
6c7eede
to
fe55d05
Compare
jamiehenson
requested review from
kennethkalmer and
denissellu
and removed request for
kennethkalmer and
denissellu
March 11, 2024 16:03
@kennethkalmer @denissellu I've migrated the two components Dominik mentioned in the PR description away into |
kennethkalmer
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket Link / Motivation
https://ably.atlassian.net/browse/ACT-122
This is the next step after https://github.com/ably/website/pull/5800. We remove all VW components, leaving the preview app, deployment and other tooling intact.
With these changes in, the preview app (and possibly also our cypress setup) could get removed too, and Storybook added (which I've started in #302).
Note there are 2 components which don't have JSX component and yet are still here:
CompanyAutocomplete
FeatureFooter
They provide CSS/JS that is still used in the website repo.
EDIT (jamiehenson - 11/3/24):
CompanyAutocomplete
andFeatureFooter
assets now removed fromably-ui
, and moved towebsite
via this PR.Summary of changes
See commits for details.
I've taken some shortcuts, assuming the preview app is on it's way out:
How do you manually test this?
Head over to the review app and click around!
Reviewer Tasks (optional)
Merge/Deploy Checklist
Frontend Checklist