Merge pull request #304 from ably/remove-view-component-support

[ACT-122] Remove view component support / ably-ui gem

.circleci/config.yml

@@ -31,7 +31,7 @@ executors:
       - YARN_VERSION: 1.22.10
 
 caches:
-  - &bundle_cache ably-ui-preview-bundle-v1-{{ checksum "Gemfile.lock" }}-{{ checksum "preview/Gemfile.lock" }}
+  - &bundle_cache ably-ui-preview-bundle-v1-{{ checksum "preview/Gemfile.lock" }}
   - &yarn_cache ably-ui-preview-yarn-v1-{{ checksum "yarn.lock" }}-{{ checksum "preview/yarn.lock" }}
 
 commands:
@@ -77,7 +77,6 @@ commands:
     steps:
       - restore_bundle_cache
       - install_bundler
-      - run: bundle install --path vendor/bundle
       - run: |
           cd preview
           bundle config set --local path 'vendor/bundle'

.npmignore

@@ -1,17 +1,12 @@
 .babelrc
 .bundle
-.bundle
 .DS_Store
 .editorconfig
 .eslintrc.js
 .pretterrc.json
 .prettierignore
-*.html.rb
-*.rb
 ably-ui-*.gem
 ably-ui.gemspec
-Gemfile
-Gemfile.lock
 lib
 modules-config.js
 node_modules

README.md

@@ -1,5 +1,3 @@
-**_Note:_** some features are still in development and their documentation might be incomplete. Lookout for the ⚠️ icon.
-
 # ably-ui
 
 `ably-ui` is the of home of the Ably design system library ([https://ably-ui.herokuapp.com/](https://ably-ui.herokuapp.com/)). It provides a showcase, development/test environment and a publishing pipeline for different distributables.

cypress/e2e/core/contact_footer/__snapshots__/snapshots.cy.js.snap

@@ -1,17 +1,4 @@
-exports[`Chat button state > react > the button is inactive without Hubspot widget #0`] = `
-<button
-  type="button"
-  class="ui-btn-secondary self-start mt-16"
-  disabled=""
-  data-id="open-chat-widget"
-  data-enabled-label="Start a live chat"
-  data-disabled-label="Live chat unavailable"
->
-  Live chat unavailable
-</button>
-`;
-
-exports[`Chat button state > vw > the button is inactive without Hubspot widget #0`] = `
+exports[`Chat button state > the button is inactive without Hubspot widget #0`] = `
 <button
   type="button"
   class="ui-btn-secondary self-start mt-16"

cypress/e2e/core/contact_footer/behaviour.cy.js

@@ -1,58 +1,51 @@
 describe("Live Chat button", () => {
-  const url = "/components/contact-footer";
-  const sharedExample = (url) => {
-    it("should be active when hubspot widget is defined and widget is present", () => {
-      cy.visit(url, {
-        onBeforeLoad(window) {
-          window.HubSpotConversations = { widget: { open: () => {} } };
-          cy.spy(window.HubSpotConversations.widget, "open").as("widgetOpen");
-        },
-      });
-
-      cy.document().then((document) => {
-        const fakeChat = document.createElement("div");
-        fakeChat.id = "hubspot-messages-iframe-container";
-        document.body.append(fakeChat);
-      });
-
-      cy.get("[data-id='open-chat-widget']").contains("Start a live chat");
-      cy.get("[data-id='open-chat-widget']").trigger("click");
-      cy.get("@widgetOpen").should("be.called");
+  beforeEach(() => {
+    cy.visit("/components/contact-footer");
+  });
+
+  it("should be active when hubspot widget is defined and widget is present", () => {
+    cy.visit("/components/contact-footer", {
+      onBeforeLoad(window) {
+        window.HubSpotConversations = { widget: { open: () => {} } };
+        cy.spy(window.HubSpotConversations.widget, "open").as("widgetOpen");
+      },
     });
 
-    it("should be inactive when hubspot widget is undefined", () => {
-      cy.visit(url, {
-        onBeforeLoad(window) {
-          window.HubSpotConversations = { widget: undefined };
-        },
-      });
+    cy.document().then((document) => {
+      const fakeChat = document.createElement("div");
+      fakeChat.id = "hubspot-messages-iframe-container";
+      document.body.append(fakeChat);
+    });
 
-      cy.document().then((document) => {
-        const fakeChat = document.createElement("div");
-        fakeChat.id = "hubspot-messages-iframe-container";
-        document.body.append(fakeChat);
-      });
+    cy.get("[data-id='open-chat-widget']").contains("Start a live chat");
+    cy.get("[data-id='open-chat-widget']").trigger("click");
+    cy.get("@widgetOpen").should("be.called");
+  });
 
-      cy.get("[data-id='open-chat-widget']").contains("Live chat unavailable");
+  it("should be inactive when hubspot widget is undefined", () => {
+    cy.visit("/components/contact-footer", {
+      onBeforeLoad(window) {
+        window.HubSpotConversations = { widget: undefined };
+      },
     });
 
-    it("should be inactive when hubspot widget is not on the page", () => {
-      cy.visit(url, {
-        onBeforeLoad(window) {
-          window.HubSpotConversations = { widget: { open: () => {} } };
-          cy.spy(window.HubSpotConversations.widget, "open").as("widgetOpen");
-        },
-      });
-
-      cy.get("[data-id='open-chat-widget']").contains("Live chat unavailable");
+    cy.document().then((document) => {
+      const fakeChat = document.createElement("div");
+      fakeChat.id = "hubspot-messages-iframe-container";
+      document.body.append(fakeChat);
     });
-  };
 
-  describe("react", () => {
-    sharedExample(url);
+    cy.get("[data-id='open-chat-widget']").contains("Live chat unavailable");
   });
 
-  describe("vw", () => {
-    sharedExample(`${url}?framework=vw`);
+  it("should be inactive when hubspot widget is not on the page", () => {
+    cy.visit("/components/contact-footer", {
+      onBeforeLoad(window) {
+        window.HubSpotConversations = { widget: { open: () => {} } };
+        cy.spy(window.HubSpotConversations.widget, "open").as("widgetOpen");
+      },
+    });
+
+    cy.get("[data-id='open-chat-widget']").contains("Live chat unavailable");
   });
 });