Add Util::BacktraceException wrapper #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksedgwic
force-pushed
the
2024-07-exception-backtrace
branch
from
1ba2052 to
b8da967
Compare
ksedgwic
force-pushed
the
2024-07-exception-backtrace
branch
from
b8da967 to
7e4f070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Added
Util::BacktraceExceptionwhich captures backtraces where an exception is thrown and then formats them for debugging when they are displayed withwhat(). The backtraces are more useful if the following configuration is used:./configure CXXFLAGS="-g -Og"but this results in larger, less optimized binaries.Motivation
When an unexpected exception occurs on a user's machine we typically get a very terse "parse error" or similar message. This PR adds logging of the stack backtrace where the exception was encountered, greatly increasing the likelihood of finding the problem from the reported log alone.