Release v0.14.0 Tracker

[ksedgwic]

CLBOSS v0.14.0 Release Checklist

Already Merged:

• Add Util::BacktraceException wrapper #225
• diagrams: Add missing MoveFundsCommand to channel balancing diagram #220
• contrib: Add clboss-channel-stats to summarize fee income performance #226
• Miscellaneous Fixes and Improvements #232
• Add time buckets and forwarded and rebalanced volume #231

Ready:

• contrib: Improve clboss-routing-stats #236
• Updated ChangeLog for v0.14.0 #238

TODO:

• choose release name
• update CHANGLOG
• make RC

[CMDRZOD]

v14 Rc1 and RC2 both give me this error during build:

Boss/Mod/Initiator.cpp:1:9: fatal error: commit_hash.h: No such file or directory
1 | #include"commit_hash.h"
| ^~~~~~~~~~~~~~~
compilation terminated. make[2]: *** [Makefile:4682: Boss/Mod/libclboss_la-Initiator.lo] Error 1

I'm trying to upgrade to v14 because v13 crashes the latest core lightning on startup for me. Topology error or crash is reported when I startup with clboss 13 plugin.

[chrisguida]

@CMDRZOD are you building from the git repo or the source tarball?

[CMDRZOD]

Im using the source tarball.

[ksedgwic]

Looks like something is amiss ... investigating ...

[ksedgwic]

That was an ordeal ...

@CMDRZOD could you please see if https://github.com/ZmnSCPxj/clboss/releases/tag/v0.14.0-rc16 works for you?

And many thanks for checking and reporting this issue, good to get it resolved ...

[CMDRZOD]

Same issue with that build unfortunately. Still using source tarball.
Boss/Mod/Initiator.cpp:1:9: fatal error: commit_hash.h: No such file or directory 1 | #include"commit_hash.h" | ^~~~~~~~~~~~~~~ compilation terminated.

[ksedgwic]

Pleas try the other source tarball labeled clboss-v0.14.0-rc16.tar.gz
... I need to figure out how to get rid of the generic "Source code" ones

[ksedgwic]

The difference is:

• "Source code (zip and tar.gz)" - generated using the repo source w/o any processing
• "clboss-v0.14.0" - generated using the clboss make dist (and make dist-zip) to generate "distribution tarballs"

We're going to have better luck going forward w/ the make dist versions because they allow for checking and processing when being built ...

[CMDRZOD]

Yep that one builds successfully. However still getting a crash at startup with the latest core lightning release. (24.08)

topology: FATAL SIGNAL 11 (version v24.08)

[ksedgwic]

Any chance there is a backtrace in the log or output to stderr? Or a corefile?

[CMDRZOD]

Wall of text below

topology: FATAL SIGNAL 11 (version v24.08) 0x595c27a3ab20 send_backtrace common/daemon.c:33 0x595c27a3abb7 crashdump common/daemon.c:75 0x72bfab24251f ??? ???:0 0x595c27a1b4fd gossmap_remove_localmods common/gossmap.c:984 0x595c27a27f38 listpeerchannels_done plugins/topology.c:450 0x595c27a2c911 handle_rpc_reply plugins/libplugin.c:1016 0x595c27a2cab1 rpc_read_response_one plugins/libplugin.c:1202 0x595c27a2cb62 rpc_conn_read_response plugins/libplugin.c:1226 0x595c27b5f09f next_plan ccan/ccan/io/io.c:60 0x595c27b5f57e do_plan ccan/ccan/io/io.c:422 0x595c27b5f63b io_ready ccan/ccan/io/io.c:439 0x595c27b6103e io_loop ccan/ccan/io/poll.c:455 0x595c27a2d239 plugin_main plugins/libplugin.c:2230 0x595c27a28126 main plugins/topology.c:750 0x72bfab229d8f ??? ???:0 0x72bfab229e3f ??? ???:0 0x595c27a187b4 ??? ???:0 0xffffffffffffffff ??? ???:0 2024-10-02T23:58:45.389Z DEBUG 035e4ff418fc8b5554c5d9eea66396c227bd429a3251c8cbc711002ba215bfc226-connectd: Connected out, starting crypto 2024-10-02T23:58:45.481Z DEBUG 03cde60a6323f7122d5178255766e38114b4722ede08f7c9e0c5df9b912cc201d6-connectd: Connected out, starting crypto 2024-10-02T23:58:45.488Z DEBUG 02a20247f515d978cbf9e9ce6a4287b5931d724068b7b88bbaead6380db3dd8e9a-hsmd: Got WIRE_HSMD_ECDH_REQ 2024-10-02T23:58:45.488Z DEBUG hsmd: Client: Received message 1 from client 2024-10-02T23:58:45.488Z DEBUG 035e4ff418fc8b5554c5d9eea66396c227bd429a3251c8cbc711002ba215bfc226-connectd: Connect OUT 2024-10-02T23:58:45.488Z DEBUG 035e4ff418fc8b5554c5d9eea66396c227bd429a3251c8cbc711002ba215bfc226-connectd: peer_out WIRE_INIT 2024-10-02T23:58:45.496Z INFO plugin-topology: Killing plugin: exited during normal operation 2024-10-02T23:58:45.496Z **BROKEN** plugin-topology: Plugin marked as important, shutting down lightningd! 2024-10-02T23:58:45.497Z DEBUG lightningd: io_break: lightningd_exit 2024-10-02T23:58:45.497Z DEBUG connectd: REPLY WIRE_CONNECTD_START_SHUTDOWN_REPLY with 0 fds 2024-10-02T23:58:45.497Z DEBUG lightningd: io_break: connectd_start_shutdown_reply 2024-10-02T23:58:45.500Z DEBUG lightningd: io_break: destroy_plugin 2024-10-02T23:58:45.500Z DEBUG connectd: Shutting down terminate called after throwing an instance of 'Util::BacktraceException<std::runtime_error>' Lost connection to the RPC socket. what(): Rpc: read: unexpected end-of-file in RPC socket. Backtrace: #0 /home/hair/clboss-0.14.0/clboss(+0x534c99) [0x6499820afc99] #1 /home/hair/clboss-0.14.0/clboss(+0x534e3a) [0x6499820afe3a] #2 /home/hair/clboss-0.14.0/clboss(+0xfae36) [0x649981c75e36] #3 /home/hair/clboss-0.14.0/clboss(+0x52bac9) [0x6499820a6ac9] #4 /lib/x86_64-linux-gnu/libev.so.4(ev_invoke_pending+0x53) [0x73b06912b773] #5 /lib/x86_64-linux-gnu/libev.so.4(ev_run+0x811) [0x73b06912f041] #6 /home/hair/clboss-0.14.0/clboss(+0xf4396) [0x649981c6f396] #7 /home/hair/clboss-0.14.0/clboss(+0xc8f35) [0x649981c43f35] #8 /lib/x86_64-linux-gnu/libc.so.6(+0x29d90) [0x73b068829d90] #9 /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0x80) [0x73b068829e40] #10 /home/hair/clboss-0.14.0/clboss(+0xcc3a5) [0x649981c473a5] cln-renepay: gossmap: redundant channel_announce for 858307x1702x0, offsets 1304052 and 3121918! lightning_connectd: gossmap: redundant channel_announce for 858307x1702x0, offsets 1304052 and 3121918! 2024-10-02T23:58:46.513Z DEBUG gossipd: Shutting down 2024-10-02T23:58:46.565Z DEBUG hsmd: Shutting down

[ksedgwic]

This looks similar to ElementsProject/lightning#7685

Your crash is in the topology plugin and this crash is in plugin pay, but the crashing routine (and the gossip store) are common to both.

If possible it would be good to file an issue w/ CLN and add a link to the above PR.

It's quite possible that CLBOSS is making this happen because it leans heavily on the topology plugin

[ksedgwic]

ah, another user fixed the issue w/ the following procedure:
ElementsProject/lightning#7685 (comment)

---FINAL UPDATE---
Able to resolve my issue by reading a lot and by:

shutting every thing down and rebooting system
deleting gossip_store and gossip_store.corrupt
restarting lightningd
gossip_store has been re-created and based on its previous file size it appears it will take several hours to complete.
The answer to the question 'Is it safe to delete gossip_store?' is yes.
---NO FURTHER ACTION REQUIRED---

[CMDRZOD]

Wow thank you! I will give this a try and report back.

Edit: Can confirm this fixed my node crashing at startup. Thanks again!

[ksedgwic]

Closing as released

[btchans]

https://github.com/ZmnSCPxj/clboss/releases/tag/v0.14.0
Used this tarball and got the same issue:

Boss/Mod/Initiator.cpp:1:9: fatal error: commit_hash.h: No such file or directory
1 | #include"commit_hash.h"

tried rc16 and it compiled through.

[ksedgwic]

Make sure you are using the tarball with the version in the name I'll try to figure out how to get rid of the "automatically" generated tarballs, they are not generated with `make dist` ...

…

-- Ken Sedgwick Bonsai Software, Inc. http://www.bonsai.com/ken/ (510) 269-7334 ***@***.*** Public Key: http://www.bonsai.com/ken/ken.asc GPG Fingerprint: 4695 E5B8 F781 BF85 4326 9639 BBFC E515 8602 5550

On Mon, Oct 7, 2024, 01:55 btc_hans ***@***.***> wrote: https://github.com/ZmnSCPxj/clboss/releases/tag/v0.14.0 Used this tarball and got the same issue: Boss/Mod/Initiator.cpp:1:9: fatal error: commit_hash.h: No such file or directory 1 | #include"commit_hash.h" tried rc16 and it compiled through. — Reply to this email directly, view it on GitHub <#237 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAJNPSJIDJXGVYSPWAKSLTZ2JEAJAVCNFSM6AAAAABO3HIM36VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGMZDANRZGY> . You are receiving this because you modified the open/close state.Message ID: ***@***.***>