Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tox / CI config to more recent Python versions #384

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,10 @@ environment:
TOXENV: py36
- PYTHON: C:\Python37-x64
TOXENV: py37
- PYTHON: C:\Python38-x64
TOXENV: py38
- PYTHON: C:\Python39-x64
TOXENV: py39

build: off

Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ jobs:
- py27
- py36
- py37
- py38
- py39
- py310
- pre-commit
- mypy
- docs
Expand All @@ -19,6 +22,6 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-python@v2
with:
python-version: 3.7
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem like this file is actually being used, and I'm not sure this should be fixed with the config above.

python-version: 3.9
- run: pip install tox
- run: tox -e ${{ matrix.tox }}
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ filterwarnings =
ignore:.*will be deprecated in the next major release. Please use the more general entry-point offered in.*:DeprecationWarning

[tox]
envlist = py27, py36, py37, mypy, pre-commit
envlist = py27, py3{6,7,8,9,10}, mypy, pre-commit

[testenv]
deps =
Expand All @@ -12,7 +12,7 @@ commands =
python -m pytest --cov --capture=no --benchmark-skip {posargs:tests}

[testenv:benchmark]
basepython = python3.7
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if these need to be Python 3.7, but it would be nice to at least make the envlist change.

basepython = python3.9
deps =
-rrequirements-dev.txt
commands =
Expand All @@ -23,7 +23,7 @@ commands =
--benchmark-histogram=.benchmarks/benchmark

[testenv:mypy]
basepython = python3.7
basepython = python3.9
commands =
mypy bravado_core tests

Expand Down